Skip to content

Commit

Permalink
Menu: Update styles to use ui-widget-header for categories
Browse files Browse the repository at this point in the history
  • Loading branch information
kborchers committed Mar 16, 2012
1 parent ee79303 commit cf6fa85
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 5 deletions.
1 change: 0 additions & 1 deletion tests/visual/menu/menu.html
Expand Up @@ -79,7 +79,6 @@
<li><a href="#">Ada</a></li>
<li><a href="#">Adamsville</a></li>
<li><a href="#">Addyston</a></li>
<li></li>
<li>Group B</li>
<li>
<a href="#">Delphi</a>
Expand Down
3 changes: 1 addition & 2 deletions themes/base/jquery.ui.menu.css
Expand Up @@ -10,8 +10,7 @@
.ui-menu { list-style:none; padding: 2px; margin: 0; display:block; outline: none; }
.ui-menu .ui-menu { margin-top: -3px; position: absolute; }
.ui-menu .ui-menu-item, .ui-menu .ui-menu-category { margin: 0; padding: 0; zoom: 1; width: 100%; }
.ui-menu .ui-menu-category { font-weight: bold; border-bottom: 1px solid #AAA; line-height: 1.5; zoom: 1; }
.ui-menu .ui-menu-category span { display: block; padding: 2px .4em; }
.ui-menu .ui-widget-header { padding: 3px; }
.ui-menu .ui-menu-item a { text-decoration: none; display: block; padding: 2px .4em; line-height: 1.5; zoom: 1; font-weight: normal; }
.ui-menu .ui-menu-item a.ui-state-focus,
.ui-menu .ui-menu-item a.ui-state-active { font-weight: normal; margin: -1px; }
Expand Down
3 changes: 1 addition & 2 deletions ui/jquery.ui.menu.js
Expand Up @@ -282,9 +282,8 @@ $.widget( "ui.menu", {
menus.children( ":not( .ui-menu-item )" ).each( function() {
var item = $( this );
item
.addClass( "ui-menu-category" )
.addClass( "ui-widget-header" )
.attr( "role", "group" );
item.contents().wrapAll( "<span>" );
});

submenus.each( function() {
Expand Down

2 comments on commit cf6fa85

@kborchers
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jzaefferer This commit and c438773 should address your previous comments. Another review would be much appreciated!

@jzaefferer
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So much better :-) Let's put this into a pull request, then I'll give it a more thorough spin.

Please sign in to comment.