breaking: remove m-html in favor of m-literal:innerHTML.dom

- refactor setting DOM properties
kbrsh · Aug 29, 2017 · 02c7d2a · 02c7d2a
1 parent 3d66832
commit 02c7d2a
Show file tree

Hide file tree

Showing 4 changed files with 25 additions and 48 deletions.
diff --git a/dist/moon.js b/dist/moon.js
@@ -2117,6 +2117,14 @@
       }
     }
 
+    var addDomPropertyCodeToVNode = function(name, code, vnode) {
+      var dom = vnode.props.dom;
+      if(dom === undefined) {
+        vnode.props.dom = dom = {};
+      }
+      dom[name] = code;
+    }
+
     specialDirectives["m-if"] = {
       beforeGenerate: function(prop, vnode, parentVNode, state) {
         var children = parentVNode.children;
@@ -2285,11 +2293,7 @@
         addEventListenerCodeToVNode(eventType, code, vnode);
 
         // Setup a query used to get the value, and set the corresponding dom property
-        var dom = vnode.props.dom;
-        if(dom === undefined) {
-          vnode.props.dom = dom = {};
-        }
-        dom[domGetter] = domSetter;
+        addDomPropertyCodeToVNode(domGetter, domSetter, vnode);
       }
     };
 
@@ -2303,11 +2307,7 @@
         compileTemplateExpression(propValue, state.exclude, state.dependencies);
 
         if(modifiers[0] === "dom") {
-          var dom = vnode.props.dom;
-          if(dom === undefined) {
-            vnode.props.dom = dom = {};
-          }
-          dom[propName] = propValue;
+          addDomPropertyCodeToVNode(propName, propValue, vnode);
           return "";
         } else if(propName === "class") {
           // Detected class, use runtime class render helper
@@ -2319,18 +2319,6 @@
       }
     };
 
-    specialDirectives["m-html"] = {
-      beforeGenerate: function(prop, vnode, parentVNode, state) {
-        var value = prop.value;
-        var dom = vnode.props.dom;
-        if(dom === undefined) {
-          vnode.props.dom = dom = {};
-        }
-        compileTemplateExpression(value, state.exclude, state.dependencies);
-        dom.innerHTML = "" + value;
-      }
-    };
-
     specialDirectives["m-mask"] = {
 
     };