add better falsy values, and fix setting attributes for xlink:href (f…

…ixes #31)
kbrsh · Apr 14, 2017 · 9b90318 · 9b90318
1 parent 99ac4c8
commit 9b90318
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 7 deletions.
diff --git a/dist/moon.js b/dist/moon.js
@@ -549,15 +549,19 @@
         var vnodePropValue = vnodeProps[vnodePropName];
         var nodePropValue = nodeProps[vnodePropName];
 
-        if (vnodePropValue !== false && (nodePropValue == null || vnodePropValue !== nodePropValue)) {
-          node.setAttribute(vnodePropName, vnodePropValue === true ? '' : vnodePropValue);
+        if ((vnodePropValue !== undefined || vnodePropValue !== false || vnodePropValue !== null) && (nodePropValue === undefined || nodePropValue === false || nodePropValue === null || vnodePropValue !== nodePropValue)) {
+          if (vnodePropName.length === 10 && vnodePropName === "xlink:href") {
+            node.setAttributeNS('http://www.w3.org/1999/xlink', "href", vnodePropValue);
+          } else {
+            node.setAttribute(vnodePropName, vnodePropValue === true ? '' : vnodePropValue);
+          }
         }
       }
 
       // Diff Node Props with VNode Props
       for (var nodePropName in nodeProps) {
         var _vnodePropValue = vnodeProps[nodePropName];
-        if (_vnodePropValue === undefined || _vnodePropValue === false) {
+        if (_vnodePropValue === undefined || _vnodePropValue === false || _vnodePropValue === null) {
           node.removeAttribute(nodePropName);
         }
       }