add support for boolean attributes (fixes #238)

kbrsh · Apr 28, 2019 · acd98dc · acd98dc
1 parent a51aced
commit acd98dc
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 5 deletions.
diff --git a/packages/moon/dist/moon.js b/packages/moon/dist/moon.js
@@ -835,7 +835,7 @@
 				if (key[0] === "@") {
 					nodeData[key] = value;
 					nodeNode.addEventListener(key.slice(1), value);
-				} else if (key !== "children") {
+				} else if (key !== "children" && value !== false) {
 					nodeData[key] = value;
 					nodeNode.setAttribute(key, value);
 				}
@@ -1057,7 +1057,12 @@
 
 							if (key[0] !== "@" && key !== "children") {
 								nodeOldData[key] = value;
-								nodeOldNode.setAttribute(key, value);
+
+								if (value === false) {
+									nodeOldNode.removeAttribute(key);
+								} else {
+									nodeOldNode.setAttribute(key, value);
+								}
 							}
 						}
 

diff --git a/packages/moon/dist/moon.min.js b/packages/moon/dist/moon.min.js
diff --git a/packages/moon/src/executor/executor.js b/packages/moon/src/executor/executor.js
@@ -58,7 +58,7 @@ function executeCreate(node) {
 			if (key[0] === "@") {
 				nodeData[key] = value;
 				nodeNode.addEventListener(key.slice(1), value);
-			} else if (key !== "children") {
+			} else if (key !== "children" && value !== false) {
 				nodeData[key] = value;
 				nodeNode.setAttribute(key, value);
 			}
@@ -289,7 +289,12 @@ function executePatch(patches) {
 
 					if (key[0] !== "@" && key !== "children") {
 						nodeOldData[key] = value;
-						nodeOldNode.setAttribute(key, value);
+
+						if (value === false) {
+							nodeOldNode.removeAttribute(key);
+						} else {
+							nodeOldNode.setAttribute(key, value);
+						}
 					}
 				}