Skip to content

Commit

Permalink
remove special diff case for text
Browse files Browse the repository at this point in the history
  • Loading branch information
kbrsh committed Dec 2, 2019
1 parent 06b5d0f commit af10f7d
Show file tree
Hide file tree
Showing 11 changed files with 30 additions and 44 deletions.
4 changes: 2 additions & 2 deletions packages/moon-browser/dist/moon-browser.js
Original file line number Diff line number Diff line change
Expand Up @@ -358,11 +358,11 @@
// generated code.
outputChildren += childValue;
} else {
outputChildren += separator + "Moon.view.m.text({value:" + JSON.stringify(childValue) + "})";
outputChildren += separator + "Moon.view.m.text({data:" + JSON.stringify(childValue) + "})";
separator = ",";
}
} else if (childType === "block") {
outputChildren += separator + "Moon.view.m.text({value:" + generate(child.value[1]) + "})";
outputChildren += separator + "Moon.view.m.text({data:" + generate(child.value[1]) + "})";
separator = ",";
} else {
outputChildren += separator + generate(child);
Expand Down
2 changes: 1 addition & 1 deletion packages/moon-browser/dist/moon-browser.min.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions packages/moon-browser/test/browser.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ test("transform inline script", () => {

expect(scriptBefore).toBeUndefined();
expect(scriptAfter).not.toBeUndefined();
expect(scriptAfter.text).toEqual(`const paragraph = (Moon.view.m.p({children:[Moon.view.m.text({value:\"Moon Test\"})]}));`);
expect(scriptAfter.text).toEqual(`const paragraph = (Moon.view.m.p({children:[Moon.view.m.text({data:\"Moon Test\"})]}));`);
});

test("transform external script", () => {
Expand All @@ -68,7 +68,7 @@ test("transform external script", () => {

expect(scriptBefore).toBeUndefined();
expect(scriptAfter).not.toBeUndefined();
expect(scriptAfter.text).toEqual(`const paragraphSrc = (Moon.view.m.p({children:[Moon.view.m.text({value:\"Moon Test\"})]}));`);
expect(scriptAfter.text).toEqual(`const paragraphSrc = (Moon.view.m.p({children:[Moon.view.m.text({data:\"Moon Test\"})]}));`);
});

test("transform external script with error", () => {
Expand Down
4 changes: 2 additions & 2 deletions packages/moon-compiler/dist/moon-compiler.js
Original file line number Diff line number Diff line change
Expand Up @@ -364,11 +364,11 @@
// generated code.
outputChildren += childValue;
} else {
outputChildren += separator + "Moon.view.m.text({value:" + JSON.stringify(childValue) + "})";
outputChildren += separator + "Moon.view.m.text({data:" + JSON.stringify(childValue) + "})";
separator = ",";
}
} else if (childType === "block") {
outputChildren += separator + "Moon.view.m.text({value:" + generate(child.value[1]) + "})";
outputChildren += separator + "Moon.view.m.text({data:" + generate(child.value[1]) + "})";
separator = ",";
} else {
outputChildren += separator + generate(child);
Expand Down
Loading

0 comments on commit af10f7d

Please sign in to comment.