specific cases for slight perf boost in hydration

kbrsh · Apr 4, 2017 · c05a0bc · c05a0bc
1 parent 48395ed
commit c05a0bc
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 13 deletions.
diff --git a/dist/moon.js b/dist/moon.js
@@ -609,13 +609,13 @@
     var hydrate = function (node, vnode, parent, instance) {
       var nodeName = node ? node.nodeName.toLowerCase() : null;
 
-      if (!node) {
+      if (node === null) {
         // No node, create one
         var newNode = createNodeFromVNode(vnode, instance);
         appendChild(newNode, vnode, parent);
 
         return newNode;
-      } else if (!vnode) {
+      } else if (vnode === undefined) {
         removeChild(node, parent);
 
         return null;
@@ -624,7 +624,7 @@
         replaceChild(node, newNode, vnode, parent);
         return newNode;
       } else if (vnode.type === "#text") {
-        if (node && nodeName === "#text") {
+        if (node !== null && nodeName === "#text") {
           // Both are textnodes, update the node
           if (node.textContent !== vnode.val) {
             node.textContent = vnode.val;
@@ -643,7 +643,7 @@
         vnode.meta.el = node;
 
         // Check for Component
-        if (vnode.meta.component) {
+        if (vnode.meta.component !== undefined) {
           // Diff the Component
           diffComponent(node, vnode);
 
@@ -658,15 +658,15 @@
         addEventListeners(node, vnode, instance);
 
         // Check if innerHTML was changed, and don't diff children if so
-        if (vnode.props.dom && vnode.props.dom.innerHTML) {
+        if (vnode.props.dom !== undefined && vnode.props.dom.innerHTML !== undefined) {
           return node;
         }
 
         // Hydrate Children
         var i = 0;
         var currentChildNode = node.firstChild;
         var vchild = vnode.children[i];
-        while (vchild || currentChildNode) {
+        while (vchild !== undefined || currentChildNode !== null) {
           hydrate(currentChildNode, vchild, node, instance);
           vchild = vnode.children[++i];
           currentChildNode = currentChildNode ? currentChildNode.nextSibling : null;