Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiler Problem #8

Closed
kbrsh opened this issue Feb 17, 2017 · 0 comments
Closed

Compiler Problem #8

kbrsh opened this issue Feb 17, 2017 · 0 comments
Assignees
Labels

Comments

@kbrsh
Copy link
Owner

kbrsh commented Feb 17, 2017

When compiling something like this:

<div id="app">
  <h1>App</h1>
  <ul>
    <li m-for='item in items'>
      <span>{{item}}</span>
      <input />
    </li>
  </ul>
  <button>Some Button</button>
</div>

It will create duplicate buttons, one inside the ul element.

Edit: It's a problem with how the compiler encounters unclosed elements. It pushes all nodes into the unclosed element, it should actually create an empty one.

@kbrsh kbrsh changed the title Diffing Engine Problem Compiler Problem Feb 17, 2017
@kbrsh kbrsh self-assigned this Feb 17, 2017
@kbrsh kbrsh added the bug label Feb 17, 2017
@kbrsh kbrsh closed this as completed in 7b3681f Feb 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant