Skip to content

Commit

Permalink
fix: remove all stop words by iterating through array backwards (fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
kbrsh committed Jul 19, 2017
1 parent 8507e5f commit 388ccaa
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 4 deletions.
7 changes: 6 additions & 1 deletion dist/wade.js
Expand Up @@ -101,8 +101,9 @@

var removeStopWords = function(str) {
var words = getWords(str);
var i = words.length;

for(var i = 0; i < words.length; i++) {
while((i--) !== 0) {
if(stopWords.indexOf(words[i]) !== -1) {
words.splice(i, 1);
}
Expand Down Expand Up @@ -215,6 +216,10 @@
}
}

Wade.config = {
stopWords: stopWords
};

Wade.version = "0.3.1";

return Wade;
Expand Down
2 changes: 1 addition & 1 deletion dist/wade.min.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion src/index.js
Expand Up @@ -91,8 +91,9 @@ var removePunctuation = function(str) {

var removeStopWords = function(str) {
var words = getWords(str);
var i = words.length;

for(var i = 0; i < words.length; i++) {
while((i--) !== 0) {
if(stopWords.indexOf(words[i]) !== -1) {
words.splice(i, 1);
}
Expand Down
2 changes: 1 addition & 1 deletion test/search/process.js
Expand Up @@ -6,6 +6,6 @@ describe("Processing", function() {
const data = Wade(["ALL UPPERCASE!!", "This. is wade"]).data;

expect(data[0]).to.equal('uppercase');
expect(data[1]).to.equal('is wade');
expect(data[1]).to.equal('wade');
});
});

0 comments on commit 388ccaa

Please sign in to comment.