fix: skip over empty processed items (closes #10, thanks @dumin)

kbrsh · Jul 29, 2017 · 6c52927 · 6c52927
1 parent 35c2cbb
commit 6c52927
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 9 deletions.
diff --git a/dist/wade.js b/dist/wade.js
@@ -142,13 +142,14 @@
       }
 
       if(Array.isArray(data)) {
-        var normalizedData = [];
+        var dataLength = data.length;
+        var normalizedData = new Array(dataLength);
         var item = null;
 
-        for(var i = 0; i < data.length; i++) {
+        for(var i = 0; i < dataLength; i++) {
           item = Wade.process(data[i]);
           if(item !== false) {
-            normalizedData.push(item);
+            normalizedData[i] = item;
           }
         }
 
@@ -181,7 +182,12 @@
     Wade.index = function(data) {
       var index = {};
       for(var i = 0; i < data.length; i++) {
-        var str = getWords(data[i]);
+        var entry = data[i];
+        if(entry === undefined) {
+          continue;
+        }
+
+        var str = getWords(entry);
         for(var j = 0; j < str.length; j++) {
           var item = str[j];
           var itemLength = item.length - 1;

diff --git a/dist/wade.min.js b/dist/wade.min.js
diff --git a/src/index.js b/src/index.js
@@ -132,13 +132,14 @@ var Wade = function(data) {
   }
 
   if(Array.isArray(data)) {
-    var normalizedData = [];
+    var dataLength = data.length;
+    var normalizedData = new Array(dataLength);
     var item = null;
 
-    for(var i = 0; i < data.length; i++) {
+    for(var i = 0; i < dataLength; i++) {
       item = Wade.process(data[i]);
       if(item !== false) {
-        normalizedData.push(item);
+        normalizedData[i] = item;
       }
     }
 
@@ -171,7 +172,12 @@ Wade.process = function(item) {
 Wade.index = function(data) {
   var index = {};
   for(var i = 0; i < data.length; i++) {
-    var str = getWords(data[i]);
+    var entry = data[i];
+    if(entry === undefined) {
+      continue;
+    }
+
+    var str = getWords(entry);
     for(var j = 0; j < str.length; j++) {
       var item = str[j];
       var itemLength = item.length - 1;