Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move code-quality checks into separate Github action tasks #358

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

Art4
Copy link
Collaborator

@Art4 Art4 commented Jan 10, 2024

I've noticed that sometimes the tests with PHP 8.3 fail because of issues with the upload to codecov. This is misleading, because seeing a failed test with PHP 8.3 I assume that there is something wrong with the code.

In this PR I've split the Github action tasks into tests (with PHPUnit) and code-quality checks (phpstan, code-coverage). I've also added a new check for code-sytle using php-cs-fixer.

This way we will see at first glance what's the problem with a broken task.

@Art4 Art4 added this to the v2.5.0 milestone Jan 10, 2024
@Art4 Art4 requested a review from kbsali January 10, 2024 13:25
@Art4 Art4 self-assigned this Jan 10, 2024
Copy link

codecov bot commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (712eddb) 96.71% compared to head (1617cc2) 96.71%.

Additional details and impacted files
@@            Coverage Diff            @@
##               v2.x     #358   +/-   ##
=========================================
  Coverage     96.71%   96.71%           
  Complexity      534      534           
=========================================
  Files            27       27           
  Lines          1459     1459           
=========================================
  Hits           1411     1411           
  Misses           48       48           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@kbsali kbsali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I did not know about matrix (and it was already in place apparently 😅 )

@Art4 Art4 merged commit a7eff52 into kbsali:v2.x Jan 10, 2024
12 checks passed
@Art4 Art4 deleted the improve-github-action-jobs branch January 10, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants