Implement list view for FTA trees and Systems #247

blcham · 2024-04-11T14:14:53Z

A/C:

Systems screen have list view
FTA trees screen have list view and it is default option
it is possible to switch between list and titles view
it is described which columns of the table were not implemented due to missing data

Kasmadei · 2024-04-22T17:25:02Z

I am close to finish table. But i need to ask for some changes on backend side.
Current look with mock data is:

To get info about tree FE calls endpoint:
http://localhost:1235/fta-fmea/services/fta-fmea-server/systems/summaries
and
http://localhost:1235/fta-fmea/services/fta-fmea-server/faultTrees/summaries

Current response for "/systems" is:

{
    "@context": {
        "types": "@type",
        "components": "http://onto.fel.cvut.cz/ontologies/fta-fmea-application/has-part-component",
        "functions": "http://onto.fel.cvut.cz/ontologies/fta-fmea-application/has-function",
        "name": "http://onto.fel.cvut.cz/ontologies/fta-fmea-application/name",
        "uri": "@id",
        "failureModes": "http://onto.fel.cvut.cz/ontologies/fta-fmea-application/has-failure-mode"
    },
    "@graph": [
        {
            "uri": "http://onto.fel.cvut.cz/ontologies/fta-fmea-application/system/instance-196155154",
            "types": [
                "http://onto.fel.cvut.cz/ontologies/fta-fmea-application/system",
                "http://onto.fel.cvut.cz/ontologies/fta-fmea-application/item"
            ],
            "name": "acm1",
            "failureModes": [],
            "functions": [],
            "components": []
        }
    ]
}

And for "/faultTrees" response is almost similar:

{
    "@context": {
        "types": "@type",
        "name": "http://onto.fel.cvut.cz/ontologies/fta-fmea-application/name",
        "uri": "@id"
    },
    "@graph": [
        {
            "uri": "http://onto.fel.cvut.cz/ontologies/fta-fmea-application/fault-tree/instance1443295929",
            "types": [
                "http://onto.fel.cvut.cz/ontologies/fta-fmea-application/fault-tree"
            ],
            "name": "FC 1.1. Tlak v kabině fault event"
        },
        {
            "uri": "http://onto.fel.cvut.cz/ontologies/fta-fmea-application/fault-tree/instance22467827479333998578",
            "types": [
                "http://onto.fel.cvut.cz/ontologies/fta-fmea-application/fault-tree"
            ],
            "name": "FC_1.3. Tlak v kabině fault event"
        }
    ]
}

@kostobog Can I ask to add the missing properties for both endpoints?
@blcham And another question, will the table for systems have exactly the same structure?

blcham · 2024-04-22T20:58:48Z

@blcham And another question, will the table for systems have exactly the same structure?

No, you can assume that there is "name" of the System, but that's all for now. The most important part to show now are FTA trees.

blcham · 2024-04-23T07:15:52Z

@kostobog please implement easier part of the table and create ticket to do the rest afterwards.

blcham · 2024-04-23T09:12:15Z

@Kasmadei I realized, that i forgot to update the image (i mentioned it on the meeting but did not update the screenshot):

Kasmadei · 2024-04-25T17:14:35Z

@blcham Is it correct, that there should be a dropdown with filter for all aircraft types ? So after i select some aircraft type, i'll see in table only aircrafts with selected type.

blcham · 2024-04-26T07:00:21Z

Yes but it is not part of this ticket -- read in the screenshot "No need to do filtering yet". We do not need to do filtering nor adding fields that would realize filters there yet.

Kasmadei · 2024-04-26T17:08:31Z

@blcham I was thinking that you wanted to add some other changes in the table

blcham · 2024-04-29T14:21:20Z

Please do "docker-compose pull". There are new data to be shown in the list from this PR:
kbss-cvut/fta-fmea#84

Here is the list of newly added stuff:

system type
sub-system type
creation time
creator
last modified
last editor

kostobog · 2024-04-29T15:51:36Z

@Kasmadei @blcham
PR kbss-cvut/fta-fmea#85 adds failure rate related properties:

calculated failure rate,
FHA based failure rate and
required failure rate

blcham · 2024-04-30T11:42:47Z

@Kasmadei @blcham PR kbss-cvut/fta-fmea#85 adds failure rate related properties:

@Kasmadei make additional PR to include those fields there

blcham · 2024-04-30T12:19:05Z

Moreover, when I tried to run locally i got table from FTA page showing at System page:

Look into Figma about columns and comment it if we need to adjust it here or there.

Kasmadei · 2024-05-01T15:57:50Z

@kostobog Hi. I've received the following response from the endpoint:
GET http://localhost:1235/services/fta-fmea-server/faultTrees/summaries
It seems that there aren't enough new properties. Could you please check? ?

{
    "@context": {
        "types": "@type",
        "components": "http://onto.fel.cvut.cz/ontologies/fta-fmea-application/has-part-component",
        "system": "http://onto.fel.cvut.cz/ontologies/fta-fmea-application/is-artifact-of",
        "functions": "http://onto.fel.cvut.cz/ontologies/fta-fmea-application/has-function",
        "name": "http://onto.fel.cvut.cz/ontologies/fta-fmea-application/name",
        "subsystem": "http://onto.fel.cvut.cz/ontologies/fta-fmea-application/is-performed-by",
        "requiredFailureRate": "http://onto.fel.cvut.cz/ontologies/fta-fmea-application/required-failure-rate",
        "uri": "@id",
        "failureModes": "http://onto.fel.cvut.cz/ontologies/fta-fmea-application/has-failure-mode"
    },
    "@graph": [
        {
            "uri": "http://onto.fel.cvut.cz/ontologies/fta-fmea-application/fault-tree/instance1443295929",
            "types": [
                "http://onto.fel.cvut.cz/ontologies/fta-fmea-application/named-entity",
                "http://onto.fel.cvut.cz/ontologies/fta-fmea-application/managed-entity",
                "http://onto.fel.cvut.cz/ontologies/fta-fmea-application/fault-tree"
            ],
            "requiredFailureRate": 4.0E-4,
            "name": "FC 1.1. Tlak v kabině fault event",
            "system": {
                "uri": "http://onto.fel.cvut.cz/ontologies/fta-fmea-application/system/instance510539860",
                "types": [
                    "http://onto.fel.cvut.cz/ontologies/fta-fmea-application/system",
                    "http://onto.fel.cvut.cz/ontologies/fta-fmea-application/item",
                    "http://onto.fel.cvut.cz/ontologies/fta-fmea-application/named-entity",
                    "http://onto.fel.cvut.cz/ontologies/fta-fmea-application/managed-entity"
                ],
                "name": "acm1",
                "failureModes": [],
                "functions": [],
                "components": []
            },
            "subsystem": {
                "uri": "http://onto.fel.cvut.cz/ontologies/fta-fmea-application/sns-component/instance-1061356481",
                "types": [
                    "http://onto.fel.cvut.cz/ontologies/fta-fmea-application/item",
                    "http://onto.fel.cvut.cz/ontologies/fta-fmea-application/named-entity",
                    "http://onto.fel.cvut.cz/ontologies/fta-fmea-application/managed-entity"
                ],
                "name": "Pressurization control",
                "failureModes": [],
                "functions": [],
                "components": []
            }
        },
        {
            "uri": "http://onto.fel.cvut.cz/ontologies/fta-fmea-application/fault-tree/instance22467827479333998578",
            "types": [
                "http://onto.fel.cvut.cz/ontologies/fta-fmea-application/named-entity",
                "http://onto.fel.cvut.cz/ontologies/fta-fmea-application/managed-entity",
                "http://onto.fel.cvut.cz/ontologies/fta-fmea-application/fault-tree"
            ],
            "requiredFailureRate": 0.003,
            "name": "FC_1.3. Tlak v kabině fault event",
            "system": {
                "uri": "http://onto.fel.cvut.cz/ontologies/fta-fmea-application/system/instance510539860",
                "types": [
                    "http://onto.fel.cvut.cz/ontologies/fta-fmea-application/system",
                    "http://onto.fel.cvut.cz/ontologies/fta-fmea-application/item",
                    "http://onto.fel.cvut.cz/ontologies/fta-fmea-application/named-entity",
                    "http://onto.fel.cvut.cz/ontologies/fta-fmea-application/managed-entity"
                ],
                "name": "acm1",
                "failureModes": [],
                "functions": [],
                "components": []
            },
            "subsystem": {
                "uri": "http://onto.fel.cvut.cz/ontologies/fta-fmea-application/sns-component/instance-1061356481",
                "types": [
                    "http://onto.fel.cvut.cz/ontologies/fta-fmea-application/item",
                    "http://onto.fel.cvut.cz/ontologies/fta-fmea-application/named-entity",
                    "http://onto.fel.cvut.cz/ontologies/fta-fmea-application/managed-entity"
                ],
                "name": "Pressurization control",
                "failureModes": [],
                "functions": [],
                "components": []
            }
        }
    ]
}

kostobog · 2024-05-03T08:27:29Z

@Kasmadei
Some of the properties are missing in the example. Specifically:

created, creator, last edited, last editor and calculated failure rate.

I am no sure why there is no FHA based failure rate. I will check today and let you know.

Kasmadei · 2024-05-06T15:21:53Z

@kostobog Hi, any updates ?

…and-trees-view [#247] Fixes for system table

blcham · 2024-05-06T17:07:48Z

@Kasmadei please check data from backend most likely it is updated according to last @kostobog comment.

blcham · 2024-05-06T17:42:44Z

@Kasmadei please past here a picture which fields work.

Kasmadei · 2024-05-06T17:57:32Z

@blcham @kostobog looks like i don't have any trees from response, can you check it please?

GET
http://localhost:1235/services/fta-fmea-server/faultTrees/summaries
Response: {"@context":{},"@graph":[]}

I did a docker update with previously provided instruction:

make sure that fork akaene/fta-fmea-ui is synced with kbss-cvut/ftea-fmea-ui
cd fta-fmea-ui (assuming it is from akaene fork)
git pull
cd deploy/internal-auth
docker-compose pull
docker-compose down
docker-compose up

blcham · 2024-05-06T20:14:11Z

@Kasmadei following the steps above it worked for me. Did you get some error?

Kasmadei · 2024-05-07T13:50:35Z

@blcham Yes, and /systems works correct, i see the same as you, but for /faultTrees endpoint response is empty :/ In an hour i'll check it again

Edit: Tried from start and i see the same. Endpoint http://localhost:1235/services/fta-fmea-server/faultTrees/summaries has empty response.

kostobog · 2024-05-08T16:01:30Z

@blcham I tested running fta-fmea-ui/depoly/internal-auth and checked services/db-server. It seams that the import script does not work properly. I can see only one trig file is imported from the shared/db-server/import/fta-fmea/ava.

@Kasmadei
I updated the fields returned in the fault tree summary, for more details see #274 (#275 fixing error in the new example data) and kbss-cvut/fta-fmea#90 .

Now you should be able to get all fields necessary for the table except for status:

created
creator - should have uri and username
modified
lastEditor - should have uri and username
system (Aircraft type ) - there should be uri and name of the aircraft
subsystem (ATA) - there should be uri and name of the subsystem, the name is composed of the ATA code and the ATA name
calculatedFailureRate
requiredFailureRate
fhaBasedFailureRate

Here is a snippet of one of the summary of one of the fault trees:

calculatedFailureRate : 0.10005625498722481
created : "2024-04-01T10:45:00Z"
creator : {uri: "http://onto.fel.cvut.cz/ontologies/fta-fmea-application/user/test-user-1",…}
	types : ["http://xmlns.com/foaf/0.1/Person"]
	uri:"http://onto.fel.cvut.cz/ontologies/fta-fmea-application/user/test-user-1"
	username:"test-user-1"
fhaBasedFailureRate : 0.01
lastEditor : {uri: "http://onto.fel.cvut.cz/ontologies/fta-fmea-application/user/test-user-2",…}
	types : ["http://xmlns.com/foaf/0.1/Person"]
	uri : "http://onto.fel.cvut.cz/ontologies/fta-fmea-application/user/test-user-2"
	username : "test-user-2"
name : "FC 1.1. Tlak v kabině fault event"
requiredFailureRate : 0.0004
subsystem : {uri: "http://onto.fel.cvut.cz/ontologies/fta-fmea-application/sns-component/instance-1061356481",…}
	components : []
	failureModes : []
	functions : []
	name : "21-30-00 - Pressurization control"
	types : ["http://onto.fel.cvut.cz/ontologies/fta-fmea-application/item",…]
	uri : "http://onto.fel.cvut.cz/ontologies/fta-fmea-application/sns-component/instance-1061356481"
system : {uri: "http://onto.fel.cvut.cz/ontologies/fta-fmea-application/system/instance510539860",…}
	components : []
	failureModes : []
	functions : []
	name : "acm1"
	types : ["http://onto.fel.cvut.cz/ontologies/fta-fmea-application/system",…]
	uri : "http://onto.fel.cvut.cz/ontologies/fta-fmea-application/system/instance510539860"
types : ["http://onto.fel.cvut.cz/ontologies/fta-fmea-application/named-entity",…]
uri : "http://onto.fel.cvut.cz/ontologies/fta-fmea-application/fault-tree/instance1443295929"

kostobog · 2024-05-09T13:52:31Z

@Kasmadei Until this issue #276 is resolved you can deploy the example data to db-server manually. To do so first run internal-auth as usual. Visit localhost:1235/services/db-server and follow the steps:

select fta-fmea repository from the menu
import data - in import page select the server files. To import a file click the import button. This will open the import dialog. In the dialog click import button. Import the following files:

for fta-fmea/ava/ava-fta-example-associated-with-fha-fault-event--anonymized.trig,
fta-fmea/ava/sns-partonomy-example--anonymized.trig and
fta-fmea/ava/user-example.trig.

in the Explore menu, on the left under Import, click Graphs overview. If import was successful you should see the following graphs:

Kasmadei · 2024-05-09T17:35:07Z

@kostobog Hi, tried your solution and for some reason i don't see fta-fmea/ava/user-example.trig file :(
Docker containers and akaene/fta-fmea-ui was synchronized with kbss.
Can i do/check something ?

blcham · 2024-05-10T08:37:16Z

@Kasmadei

I think you forgot to do docker-compose build db-server, but anyway you do not need to import data manually anymore because the issue #276 was already solved.

Do the following steps:

make sure that fork akaene/fta-fmea-ui is synced with kbss-cvut/ftea-fmea-ui
cd fta-fmea-ui (assuming it is from akaene fork)
git pull
cd deploy/internal-auth
docker-compose pull
docker-compose build (added now)
docker-compose down
docker-compose up

Kasmadei · 2024-05-10T14:45:14Z

@blcham No, i did not forget about docker-compose build db-server, and it did not help. I'll try today again :)

Kasmadei · 2024-05-10T16:31:50Z

@blcham @kostobog BE updated without any issue, but response from endpoint is still empty:

Response: {"@context":{},"@graph":[]}

curl 'http://localhost:1235/services/fta-fmea-server/faultTrees/summaries'
-H 'Accept: application/json, text/plain, /'
-H 'Accept-Language: en-GB,en-US;q=0.9,en;q=0.8'
-H 'Authorization: Bearer eyJhbGciOiJIUzUxMiJ9.eyJzdWIiOiJkZXYiLCJyb2xlcyI6WyJST0xFX1VTRVIiXSwiaWF0IjoxNzE1MzU4NDYxLCJleHAiOjE3MTUzODcyNjF9.AzSTs4Z-66xYNw3JLTOAGz827gqAAiOZXSeEEwgxUvS4RhfS_BJ6Zlyj0uzHbjPlaJ4yLjxb4Udj7jb5IUJGDw'
-H 'Connection: keep-alive'
-H 'Origin: http://localhost:5173'
-H 'Referer: http://localhost:5173/'
-H 'Sec-Fetch-Dest: empty'
-H 'Sec-Fetch-Mode: cors'
-H 'Sec-Fetch-Site: same-site'
-H 'User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/124.0.0.0 Safari/537.36'
-H 'sec-ch-ua: "Chromium";v="124", "Google Chrome";v="124", "Not-A.Brand";v="99"'
-H 'sec-ch-ua-mobile: ?0'
-H 'sec-ch-ua-platform: "macOS"'

Kasmadei · 2024-05-11T10:50:57Z

@blcham @kostobog FYI, it works good, i can keep going :)

Kasmadei · 2024-05-11T11:47:19Z

@blcham @kostobog New props added: #279
After i see more data and it length, feels like i'll need to do some minor visual changes in the table. In my screen (13') it can look a bit better.
I think only status props left.

blcham · 2024-05-12T21:09:52Z

The status will be implemented in the following issue: #280

The implementation needs to be checked, and if it is okay, we can close it.

blcham · 2024-05-12T22:15:03Z

@Kasmadei I see the following issues:

Kasmadei · 2024-05-13T15:48:17Z

After discussion we decided to add a new column for "created". I'll check how it will look with new column first.

blcham assigned Kasmadei Apr 11, 2024

blcham assigned kostobog Apr 23, 2024

kostobog mentioned this issue Apr 23, 2024

Extend fault tree summary to support list view and global system selection kbss-cvut/fta-fmea#83

Closed

Kasmadei mentioned this issue Apr 28, 2024

Feature/systems and trees overview #257

Merged

Kasmadei added a commit to akaene/fta-fmea-ui that referenced this issue Apr 29, 2024

[kbss-cvut#247] Table and card view for systems and FTA trees

0e749ec

Kasmadei mentioned this issue May 6, 2024

[#247] Fixes for system table #272

Merged

Kasmadei added a commit to akaene/fta-fmea-ui that referenced this issue May 6, 2024

[kbss-cvut#247] Fix for system table

a4a9cf3

blcham added a commit that referenced this issue May 6, 2024

Merge pull request #272 from akaene/feature/improvements-for-systems-…

fc071e0

…and-trees-view [#247] Fixes for system table

blcham mentioned this issue May 6, 2024

[Fix #83] Add calculated failure rate, fha based failure rate and failure rate requirement to fault tree summary. kbss-cvut/fta-fmea#85

Merged

blcham mentioned this issue May 12, 2024

Implement status of FTA tree #280

Open

Kasmadei mentioned this issue May 18, 2024

Fix/modified and created date #303

Merged

blcham closed this as completed in #303 May 19, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement list view for FTA trees and Systems #247

Implement list view for FTA trees and Systems #247

blcham commented Apr 11, 2024 •

edited

Loading

Kasmadei commented Apr 22, 2024 •

edited

Loading

blcham commented Apr 22, 2024 •

edited

Loading

blcham commented Apr 23, 2024 •

edited

Loading

blcham commented Apr 23, 2024

Kasmadei commented Apr 25, 2024

blcham commented Apr 26, 2024 •

edited

Loading

Kasmadei commented Apr 26, 2024

blcham commented Apr 29, 2024

kostobog commented Apr 29, 2024 •

edited by blcham

Loading

blcham commented Apr 30, 2024 •

edited

Loading

blcham commented Apr 30, 2024 •

edited

Loading

Kasmadei commented May 1, 2024 •

edited

Loading

kostobog commented May 3, 2024

Kasmadei commented May 6, 2024

blcham commented May 6, 2024

blcham commented May 6, 2024

Kasmadei commented May 6, 2024 •

edited

Loading

blcham commented May 6, 2024 •

edited

Loading

Kasmadei commented May 7, 2024 •

edited

Loading

kostobog commented May 8, 2024

kostobog commented May 9, 2024 •

edited

Loading

Kasmadei commented May 9, 2024

blcham commented May 10, 2024 •

edited

Loading

Kasmadei commented May 10, 2024

Kasmadei commented May 10, 2024

Kasmadei commented May 11, 2024

Kasmadei commented May 11, 2024

blcham commented May 12, 2024

blcham commented May 12, 2024 •

edited

Loading

Kasmadei commented May 13, 2024

Implement list view for FTA trees and Systems #247

Implement list view for FTA trees and Systems #247

Comments

blcham commented Apr 11, 2024 • edited Loading

Kasmadei commented Apr 22, 2024 • edited Loading

blcham commented Apr 22, 2024 • edited Loading

blcham commented Apr 23, 2024 • edited Loading

blcham commented Apr 23, 2024

Kasmadei commented Apr 25, 2024

blcham commented Apr 26, 2024 • edited Loading

Kasmadei commented Apr 26, 2024

blcham commented Apr 29, 2024

kostobog commented Apr 29, 2024 • edited by blcham Loading

blcham commented Apr 30, 2024 • edited Loading

blcham commented Apr 30, 2024 • edited Loading

Kasmadei commented May 1, 2024 • edited Loading

kostobog commented May 3, 2024

Kasmadei commented May 6, 2024

blcham commented May 6, 2024

blcham commented May 6, 2024

Kasmadei commented May 6, 2024 • edited Loading

blcham commented May 6, 2024 • edited Loading

Kasmadei commented May 7, 2024 • edited Loading

kostobog commented May 8, 2024

kostobog commented May 9, 2024 • edited Loading

Kasmadei commented May 9, 2024

blcham commented May 10, 2024 • edited Loading

Kasmadei commented May 10, 2024

Kasmadei commented May 10, 2024

Kasmadei commented May 11, 2024

Kasmadei commented May 11, 2024

blcham commented May 12, 2024

blcham commented May 12, 2024 • edited Loading

Kasmadei commented May 13, 2024

blcham commented Apr 11, 2024 •

edited

Loading

Kasmadei commented Apr 22, 2024 •

edited

Loading

blcham commented Apr 22, 2024 •

edited

Loading

blcham commented Apr 23, 2024 •

edited

Loading

blcham commented Apr 26, 2024 •

edited

Loading

kostobog commented Apr 29, 2024 •

edited by blcham

Loading

blcham commented Apr 30, 2024 •

edited

Loading

blcham commented Apr 30, 2024 •

edited

Loading

Kasmadei commented May 1, 2024 •

edited

Loading

Kasmadei commented May 6, 2024 •

edited

Loading

blcham commented May 6, 2024 •

edited

Loading

Kasmadei commented May 7, 2024 •

edited

Loading

kostobog commented May 9, 2024 •

edited

Loading

blcham commented May 10, 2024 •

edited

Loading

blcham commented May 12, 2024 •

edited

Loading