Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add oidc authentication #260

Merged
merged 3 commits into from
May 3, 2024
Merged

Add oidc authentication #260

merged 3 commits into from
May 3, 2024

Conversation

LaChope
Copy link
Collaborator

@LaChope LaChope commented Apr 29, 2024

Resolves #126. It mainly uses the same implementation as the record-manager-ui.

I would not merge before the backend is also implemented to test it first.

@LaChope LaChope requested a review from blcham April 29, 2024 15:26
Copy link
Contributor

@blcham blcham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see my comments

DB_SERVER_URL: "http://db-server:7200"
DB_SERVER_REPOSITORY_ID: "record-manager-app"
REPOSITORY_LANGUAGE: "en"
VOCABULARY_USER_TYPE: "http://onto.fel.cvut.cz/ontologies/record-manager/user"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be an issue, we might need to align urls.

deploy/keycloak-auth/.env Show resolved Hide resolved
src/utils/constants.tsx Outdated Show resolved Hide resolved
@LaChope LaChope merged commit 1b86372 into main May 3, 2024
1 check passed
@LaChope
Copy link
Collaborator Author

LaChope commented May 3, 2024

@blcham This PR was rebased

@LaChope LaChope deleted the oidc-support branch May 6, 2024 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide alternative authorization with keycloak
2 participants