Removed duplicate code #419
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
blcham
reviewed
Jun 18, 2024
| @@ -191,22 +191,18 @@ const FaultEventCreation = ({ useFormMethods, isRootEvent, eventValue, isEditedE | |||
| {...register("probability")} | |||
| /> | |||
|
|
|||
| {(gateTypeWatch === GateType.PRIORITY_AND || !gateTypeWatch) && | |||
There was a problem hiding this comment.
Are u sure about removing all conditions? Because in my comment i mentioned only removal of gateTypeWatch === GateType.PRIORITY_AND &&.
To be honest i did not try to understand what is code doing, i just saw redundant line of code ... should i try to understand what it does? How come you can remove all conditions ?
There was a problem hiding this comment.
I think it is not relevant anymore because the logic was changed quite a lot, so it makes sense to remove duplicate code, but I want to test the scenarios again to make sure, but #406 needs to be solved first.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.