Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finalize before first production deployment #34

Merged
merged 10 commits into from Jun 15, 2022
Merged

Finalize before first production deployment #34

merged 10 commits into from Jun 15, 2022

Conversation

blcham
Copy link

@blcham blcham commented Jun 13, 2022 •
edited

This is pull request to make first production deployment of kbss website.

Issues to consider:

  • Main/Index page:

    • ?! better picture for KBSS group (replace picture with carousel)
      • @blcham search unsplash ?
      • alternatively add to the picture some labels (such as hasChild, "is-a Child" ? :)
    • !? remove buttons "Open Mic" and "Teching" and just add links "Open mic sessions", "Teaching" instead ?
      image

  • Research projects page:

    • I am kind of missing information about when it happend -- how about adding it into structured part of description?
      image

@MichalMed if you feel there is too much stuff here, move something to separate tickets.

@github-actions github-actions bot closed this Jun 13, 2022
@blcham blcham reopened this Jun 13, 2022
@blcham blcham changed the title Update index.markdown Finalize before first production deployment Jun 13, 2022
@kbss-cvut kbss-cvut deleted a comment from github-actions bot Jun 13, 2022
@blcham blcham added this to In progress in First deployment Jun 13, 2022
@blcham
Copy link
Author

blcham commented Jun 13, 2022 •
edited

I have removed all the TODOs from all pages and moved it to tickets: #35, #37, #38.

@blcham blcham requested a review from ledsoft June 15, 2022 15:29
blcham
blcham commented Jun 15, 2022
View reviewed changes
Copy link
Author

@blcham blcham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, i cannot approved because I created the ticket, can be merged.

_pages/projects.markdown Outdated Show resolved Hide resolved
@MichalMed MichalMed requested review from MichalMed and removed request for MichalMed June 15, 2022 15:58
@blcham blcham removed the request for review from ledsoft June 15, 2022 15:59
@MichalMed MichalMed merged commit 9a36480 into master Jun 15, 2022
@MichalMed MichalMed deleted the final-review-before-release branch June 15, 2022 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ledsoft ledsoft ledsoft left review comments

@MichalMed MichalMed MichalMed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
First deployment
In progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@blcham @ledsoft @MichalMed