Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strange behaviour of wizard #323

Closed
3 tasks done
blcham opened this issue Apr 11, 2024 · 7 comments · Fixed by kbss-cvut/record-manager-ui#143 or #332
Closed
3 tasks done

Strange behaviour of wizard #323

blcham opened this issue Apr 11, 2024 · 7 comments · Fixed by kbss-cvut/record-manager-ui#143 or #332
Assignees

Comments

@blcham
Copy link
Collaborator

blcham commented Apr 11, 2024

image

In general, we do not want this behavior.

I believe such behavior is useful only in cases where we support incremental question display (i.e., questions would be shown to the user incrementally -- when he/she enters field n, the field n+1 would be shown to him)

A/C:

  • it is found out if we support incremental question display
  • default behavior is changed so user can navigate to different tab without "Next" button
  • If user must use "Next button", the Wizard tab should be grayed out with a message something like: "Navigation to this tab is disabled to prevent overlooking important questions. Use form-related buttons to navigate to this TAB instead."
@LaChope
Copy link
Collaborator

LaChope commented Apr 15, 2024

In SForms, it is possible to click "FHA classification" without clicking "Next" first.

Also, SForms does not support incremental question display, only "irrelevant" questions (e.g. is-relevant-if).

@blcham
Copy link
Collaborator Author

blcham commented Apr 15, 2024

So is it possible to find out why it is not working in record-manager?

@LaChope
Copy link
Collaborator

LaChope commented Apr 16, 2024

Actually, we support incremental question. I overlooked enableForwardSkip option. What do you think about renaming it "enableWizardStepSkip", to make it clearer?

@blcham
Copy link
Collaborator Author

blcham commented Apr 16, 2024

I am ok with renaming, but would like to know what it means that we support "incremental questions" :)

@LaChope
Copy link
Collaborator

LaChope commented Apr 16, 2024

Sorry, "incremental step" would be more appropriate. With this option, we can force user to use "Next" and "Previous" buttons to change the wizard step. IMO, if enableForwardSkip is disabled, it should be at least greyed out and have some tool tip. In this current state, it really looks like it is a bug.

@blcham
Copy link
Collaborator Author

blcham commented Apr 17, 2024

I unchecked default behavior is changed so user can navigate to different tab without "Next" button as I believe it was not solved, leaving this ticket unresolved. To resolve it we need to change SForms.

IMO, if enableForwardSkip is disabled, it should be at least greyed out and have some tool tip

I agree, it should be grayed out with a message something like: "Navigation to this tab is disabled to prevent overlooking important questions. Use form-related buttons to navigate to this TAB instead."

@LaChope
Copy link
Collaborator

LaChope commented Apr 17, 2024

I agree, it should be grayed out with a message something like: "Navigation to this tab is disabled to prevent overlooking important questions. Use form-related buttons to navigate to this TAB instead."

I added this to A/C.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants