Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split constants and vocabulary (model) into two distinct files #315

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

LaChope
Copy link
Collaborator

@LaChope LaChope commented Apr 9, 2024

Resolves #279.

IMPORTANT NOTE: After this is merged, all applications using s-forms will break and will need to be refactored according to this PR.

@LaChope LaChope requested a review from blcham April 9, 2024 14:17
Copy link

netlify bot commented Apr 9, 2024

Deploy Preview for s-forms-kbss ready!

Name Link
🔨 Latest commit fb8d67b
🔍 Latest deploy log https://app.netlify.com/sites/s-forms-kbss/deploys/66154de1b1a38100097c353a
😎 Deploy Preview https://deploy-preview-315--s-forms-kbss.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@blcham
Copy link
Collaborator

blcham commented Apr 10, 2024

Good point that it is breaking change, although not for SPipes applications but SPipesComponents. Thus we need to do it little later after we publish new version of SForms. Then we publish next version that will contain this change.

Moreover, we need to discuss conventions.E.g. we have:
Vocabulary.XSD.MAX_EXCLUSIVE
but
Vocabulary.RDFS_LABEL
-- we could also have Vocabulary.DOC, Vocabulary.FORM etc.

Other issues:


BTW, you can use https://prefix.cc/ to search for meaningful prefixes of URIs.

Copy link
Collaborator

@blcham blcham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requires more discussion on standup, see my comments.

@blcham
Copy link
Collaborator

blcham commented Apr 10, 2024

@LaChope I changed last comment to address "Other issues". Note that after changing HELP_DESCRIPTION we should change also forms (e.g. ava-model).

@LaChope
Copy link
Collaborator Author

LaChope commented Apr 10, 2024

Moreover, we need to discuss conventions.E.g. we have: Vocabulary.XSD.MAX_EXCLUSIVE but Vocabulary.RDFS_LABEL -- we could also have Vocabulary.DOC, Vocabulary.FORM etc.

I am not sure I understand fully in the end. For instance, these should be refactored like so?

static HAS_OPTION => FORM.HAS_OPTION
static HAS_OPTIONS_QUERY => FORM.HAS_OPTION_QUERY
static HAS_ANSWER => DOC.HAS_ANSWER
...

@blcham
Copy link
Collaborator

blcham commented Apr 10, 2024

yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Split Constants and Model
2 participants