Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider replacing react-breadcrumbs #293

Closed
ledsoft opened this issue Jun 15, 2022 · 2 comments
Closed

Consider replacing react-breadcrumbs #293

ledsoft opened this issue Jun 15, 2022 · 2 comments

Comments

@ledsoft
Copy link
Contributor

ledsoft commented Jun 15, 2022

React-breadcrumbs is no longer developed and it has a peer dependency on React 16, which causes npm install issues since we are already on React 17.

We should consider replacing the library with something more up-to-date with equivalent functionality.

@filip-kopecky
Copy link
Contributor

There are two options how to handle this issue.

React Router in v6.4 supports react-breadcrumbs natively. I think it would be better for longevity to update React router to the latest version and use the breadcrumbs described here.

Other option is to stay on current version of React Router and use this npm package. It would definetely be faster to implement, but it is a temporary fix.

Question is, how important this issue is. If the migration to React Router is something which would have to be done sooner or later, this might be a good opportunity to do so. @ledsoft ?

@ledsoft
Copy link
Contributor Author

ledsoft commented Dec 6, 2022

Ok, I guess it makes sense to bite the bullet and do the migration now, because we would have to do it eventually. So please, go ahead and implement them using React Router v6.

filip-kopecky added a commit to filip-kopecky/termit-ui that referenced this issue Dec 14, 2022
…nents

Removed all Switch components, replaced it with Routes. Due to naming conflict, it is called ReactRouterRoutes.
filip-kopecky added a commit to filip-kopecky/termit-ui that referenced this issue Dec 14, 2022
…todos

Component <Route/> accepts only property element as the component
filip-kopecky added a commit to filip-kopecky/termit-ui that referenced this issue Dec 16, 2022
filip-kopecky added a commit to filip-kopecky/termit-ui that referenced this issue Dec 21, 2022
filip-kopecky added a commit to filip-kopecky/termit-ui that referenced this issue Feb 9, 2023
filip-kopecky added a commit to filip-kopecky/termit-ui that referenced this issue Feb 9, 2023
@ledsoft ledsoft closed this as completed Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants