Revert "Re-use the metadata_labels variable for node_labels" #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 170bf26, because adding the node_labels to the default node pool requires a destroy and re-create on the AKS cluster. This is likely due to the node_pool using the legacy `default_node_pool` block of the `azurerm_kubernetes_cluster` resource. Must migrate to using a `azurerm_kubernetes_cluster_node_pool`. Will tackle this as part of revamping node pools support in general. Opening an issue to track this: #172
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 170bf26, because adding
the node_labels to the default node pool requires a destroy and re-create on
the AKS cluster.
This is likely due to the node_pool using the legacy
default_node_poolblock of the
azurerm_kubernetes_clusterresource. Must migrate to usinga
azurerm_kubernetes_cluster_node_pool. Will tackle this as part ofrevamping node pools support in general.
Opening an issue to track this:
#172