Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add guess_accelerator for gpus-cabaple workloads on GKE #303

Merged
merged 1 commit into from
May 23, 2023

Conversation

anhdle14
Copy link
Contributor

No description provided.

Copy link
Member

@pst pst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sending this Duc. I left a few comments that we need to address before I can consider merging this.

google/_modules/gke/node_pool/variables.tf Outdated Show resolved Hide resolved
google/_modules/gke/node_pool/variables.tf Outdated Show resolved Hide resolved
tests/gke_zero_node_pools.tf Outdated Show resolved Hide resolved
@anhdle14 anhdle14 force-pushed the feat/gke_guest_accelerator branch 2 times, most recently from 4dbdb42 to 9cc167a Compare March 30, 2023 23:37
google/_modules/gke/node_pool/main.tf Outdated Show resolved Hide resolved
tests/gke_zero_node_pools.tf Outdated Show resolved Hide resolved
@pst pst merged commit bb5908c into kbst:master May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants