Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EKS: Add AutoscaleRole to worker. #66

Closed
wants to merge 1 commit into from

Conversation

youngnicks
Copy link

Fixes #65

Without this policy, the cluster-autoscaler does not work.

@pst
Copy link
Member

pst commented Jul 22, 2019

Thanks for the issue and the PR. I am not convinced adding the role to all nodes is the best approach though. I think it would be preferable if the role was only available to the autoscaler itself.

While getting this right is more complex, this is something I will have to do as part of #63 anyway, so that the pipeline can be run using Tekton inside the cluster. Current plan is to do this via Kiam so that not all the nodes have admin roles required to configure the cluster and its AWS resources.

In the meantime, your approach is an ok workaround of course.

@youngnicks
Copy link
Author

I agree that it isn't ideal putting it on every node and is just a workaround. Kiam definitely looks like the best way to go.

@pst
Copy link
Member

pst commented Sep 6, 2019

Getting back to this it seems AWS finally came around with a viable solution similar to the GKE workload identity.

https://aws.amazon.com/blogs/opensource/introducing-fine-grained-iam-roles-service-accounts/

I will try this for #63 and when it works, will apply the same for autoscaling here aswell.

@pst
Copy link
Member

pst commented Aug 23, 2021

IAM roles for service account are supported for a couple of releases and can be used to map a K8s service account to a IAM role. That K8s service account can be configured for the pod the autoscaler runs in. Therefor allowing to limit access only to the autoscaler and no other workload that happens to be scheduled onto the node.

@pst pst closed this Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EKS: Add role to allow cluster autoscaler
2 participants