Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to make the self label uniform when using a load balancer #290

Merged
merged 2 commits into from
Jul 21, 2022

Conversation

lphuberdeau
Copy link

@lphuberdeau lphuberdeau commented Jul 19, 2022

Implements #230

Changes from the proposed spec:

  • Using RABBIT_CONNECTION instead of RABBITMQ_CONNECTION as it seemed to fit better with the conventions in use.
  • The self label is not removed, only uniformly set as "lb". Removing it entirely required more complex changes.

@kbudde
Copy link
Owner

kbudde commented Jul 20, 2022

Hello @lphuberdeau ,
Thank you for this change. I really enjoy the simplicity.

Only a small thing needs to be changed: Please set self label to "lb" instead of "1".

BR

@lphuberdeau
Copy link
Author

Thanks for the quick feedback and the detailed feature proposal.

@kbudde kbudde merged commit 2231dcf into kbudde:main Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants