Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type VAL (+TypeVariableImpl is not supported yet. #95

Closed
magx2 opened this issue Oct 27, 2023 · 14 comments · Fixed by #96
Closed

Type VAL (+TypeVariableImpl is not supported yet. #95

magx2 opened this issue Oct 27, 2023 · 14 comments · Fixed by #96

Comments

@magx2
Copy link

magx2 commented Oct 27, 2023

Hey,

I have another issue. When running your plugin I'm getting this error: Type VAL (+TypeVariableImpl is not supported yet.. I don't know what is causing it, maybe Lombok?

Caused by: java.lang.RuntimeException: Type VAL (+TypeVariableImpl is not supported yet.
    at io.github.kbuntrock.model.DataObject.<init> (DataObject.java:141)
    at io.github.kbuntrock.TagLibrary.inspectObject (TagLibrary.java:113)
    at io.github.kbuntrock.TagLibrary.exploreDataObject (TagLibrary.java:87)
    at io.github.kbuntrock.TagLibrary.inspectObject (TagLibrary.java:114)
    at io.github.kbuntrock.TagLibrary.exploreDataObject (TagLibrary.java:77)
    at io.github.kbuntrock.TagLibrary.exploreDataObject (TagLibrary.java:84)

"Type " + originalType.getTypeName() + " (+" + originalType.getClass().getSimpleName() + " is not supported yet.");

Ps In error message in DataObject.java#L140 you are missing closing ) 😉

@magx2
Copy link
Author

magx2 commented Oct 27, 2023

Can you please add some debug info which class and method you are parsing at the time? So it would be easier to find out what is the problem

@kbuntrock
Copy link
Owner

Gosh, I kinda like that you have some specific issues which will make this plugin better, but I feel sorry you run into so much.

Don't know about lombok, it was one of my lead on your previous bug and it didn't seem to bother the plugin.

Could you pin down the problem and enhanced your previous error demo project so I can work on it?

You can activate debug logs with the "-X" maven option. Like "mvn compile -X"

And you a right about adding informations . I should think about adding them in the error directly.

PS : if the problem is due to a single controller / method, you can then exclude it temporarily while waiting for the fix with the blacklist configuration.

@magx2
Copy link
Author

magx2 commented Oct 27, 2023

if the problem is due to a single controller / method, you can then exclude it temporarily while waiting for the fix with the blacklist configuration.

The problem is that I don't know which controller/method this is. Please add more logging (I'm already running --debug option) so I can reproduce it

@magx2
Copy link
Author

magx2 commented Oct 27, 2023

It's not lombok. I've cloned you repo and stopped with debugger.

Let me try to reproduce it

@kbuntrock
Copy link
Owner

if the problem is due to a single controller / method, you can then exclude it temporarily while waiting for the fix with the blacklist configuration.

The problem is that I don't know which controller/method this is. Please add more logging (I'm already running --debug option) so I can reproduce it

Isn't there some logs like these ones with the debug option? The last one before the error would be our candidate (can be very fast if it's the first ... :P)

[DEBUG] Parsing tag : FooController
[DEBUG] Parsing endpoint FooController
[DEBUG] Parsing request method : youAreAwesome
[DEBUG] Reading parameters from youAreAwesome
[DEBUG] Parameter : foo
[DEBUG] RequestBody annotation detected, location is BODY
[DEBUG] DataObject{openApiType=ARRAY, arrayItemDataObject=DataObject{openApiType=OBJECT, arrayItemDataObject=null}}
[DEBUG] Finished parsing endpoint : youAreAwesome - POST
--- next class (added comment, not present in real debug logs)
[DEBUG] Parsing tag : GenericController
[DEBUG] Parsing endpoint GenericController
[DEBUG] Parsing request method : setTimePage
[DEBUG] Reading parameters from setTimePage
[DEBUG] Parameter : timePage
[DEBUG] RequestBody annotation detected, location is BODY
[DEBUG] DataObject{openApiType=OBJECT, arrayItemDataObject=null}
[DEBUG] Finished parsing endpoint : setTimePage - POST
[DEBUG] Parsing request method : setAccountPage
[DEBUG] Reading parameters from setAccountPage
[DEBUG] Parameter : accountPage
[DEBUG] RequestBody annotation detected, location is BODY
[DEBUG] DataObject{openApiType=OBJECT, arrayItemDataObject=null}
[DEBUG] Finished parsing endpoint : setAccountPage - POST

@magx2
Copy link
Author

magx2 commented Oct 27, 2023

Check my project. I've pushed new commit with the error that I've mentioned

@kbuntrock
Copy link
Owner

Check my project. I've pushed new commit with the error that I've mentioned

Thank you, will work on it over the weekend.

@magx2
Copy link
Author

magx2 commented Oct 27, 2023 via email

@kbuntrock
Copy link
Owner

@magx2 : Done some work and merge to the main branch. I was handling types coming from outside, coming from the parent hierarchy, but not the two together.
Yes, genericity represent already 50% percent on my time on this project ^^ Every time I finally think I've handled everything, something new comes up.

Since you managed to clone the repo, can you pull "dev" and check the v0.0.17-SNAPHOST if there is any other bug with your project?
I will wait your check before releasing the version, in case you bring something new tomorrow. :P

@magx2
Copy link
Author

magx2 commented Oct 29, 2023 via email

@magx2
Copy link
Author

magx2 commented Oct 30, 2023

Looks like it's working 🎉😁!

@kbuntrock
Copy link
Owner

Awesome. :) I'll release over lunch break. :)

@kbuntrock
Copy link
Owner

@magx2 : v0.0.17 is up.

@magx2
Copy link
Author

magx2 commented Oct 30, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants