Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FileVault status check fails with institutional recovery key #53

Closed
jordan-hamilton opened this issue May 2, 2018 · 2 comments
Closed
Assignees
Labels

Comments

@jordan-hamilton
Copy link
Contributor

Hi @kc9wwh,

When an institutional recovery key is installed, the variable fvStatus contains:

FileVault is On. FileVault master keychain appears to be installed.

This causes the first condition on line 335 to evaluate to false.

An alternative would be something like fvStatus=$( /usr/bin/fdesetup status | awk 'NR == 1' ) on line 170.

I can create a PR if you'd like.

Thanks for all you do!

--Jordan

@timcarnold
Copy link

timcarnold commented May 3, 2018

I was able to resolve this by adding using head -1

If you have an institutional key it returns two lines. The first line returns the expected "FileVault is On". The second line returns "FileVault master keychain appears to be installed."

Your awk option would work too.

@kc9wwh kc9wwh added the bug label May 3, 2018
@kc9wwh
Copy link
Owner

kc9wwh commented May 3, 2018

Hey @jordan-hamilton and @timcarnold!

Thank you for reporting this issue. If either one of you can submit a Pull Request I’ll take a look and get this added to the master.

Thanks much for sharing!

Sent with GitHawk

kc9wwh added a commit that referenced this issue May 4, 2018
Fixed Issue #53 (@jordan-hamilton)
@kc9wwh kc9wwh closed this as completed May 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants