Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the power and space status condition #114

Merged
merged 5 commits into from Jun 4, 2019
Merged

Fix the power and space status condition #114

merged 5 commits into from Jun 4, 2019

Conversation

kenchan0130
Copy link
Collaborator

Done

  • Refactor conditions
    • To make the condition statement syntax uniform
  • Fix the power and space status condition
    • This change is main

Fix #113

@kenchan0130
Copy link
Collaborator Author

@taniguti Please check and review this PR.

taniguti
taniguti requested changes Jun 3, 2019
View reviewed changes
macOSUpgrade.sh Outdated Show resolved Hide resolved
macOSUpgrade.sh Show resolved Hide resolved
macOSUpgrade.sh Show resolved Hide resolved
taniguti
taniguti approved these changes Jun 4, 2019
View reviewed changes
Copy link
Collaborator

@taniguti taniguti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kenchan0130 kenchan0130 merged commit 671edda into kc9wwh:master Jun 4, 2019
@kenchan0130 kenchan0130 deleted the fix/power-condition branch June 4, 2019 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taniguti taniguti taniguti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

spaceStatus and pwrStatus ERROR not working
2 participants
@kenchan0130 @taniguti