Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow installation on non-Intel CPUs with MacOS, and improve error message for unsupported environments #4

Merged
merged 1 commit into from
Dec 10, 2022

Conversation

C0urante
Copy link
Contributor

@C0urante C0urante commented Dec 9, 2022

Addresses kcctl/kcctl#134

Adapted from #3

@C0urante
Copy link
Contributor Author

C0urante commented Dec 9, 2022

@gunnarmorling would you be able to take a look when you have a moment?

Copy link
Contributor

@gunnarmorling gunnarmorling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, applying. Thx! Does this require a release to homebrew, or does it pull this formula automatically without us having to do anything? That being said, it would be nice to release anyways soonish, for getting out all the recently added features.

@gunnarmorling gunnarmorling merged commit 6a72560 into kcctl:main Dec 10, 2022
@C0urante C0urante deleted the gh-134 branch December 12, 2022 13:51
@C0urante
Copy link
Contributor Author

I've just tested this out with a fresh Apple Silicon laptop and the installation went off without a hitch; looks like no release is necessary. It may be necessary for users who have already tried and failed to install kcctl to force brew to fetch the new formula, though; haven't been able to test that scenario.

Agreed on the release--are there any issues that should qualify as blockers or do we feel like this is in a good enough state to push a new one right now?

@gunnarmorling
Copy link
Contributor

gunnarmorling commented Dec 12, 2022 via email

@gunnarmorling
Copy link
Contributor

gunnarmorling commented Dec 12, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants