#295 Fix NPE for listing plugins when connector class not found #299
Conversation
|
CC @gunnarmorling 😃 |
| int exitCode = context.commandLine().execute("-f", path.toAbsolutePath().toString()); | ||
|
|
||
| assertThat(exitCode).isEqualTo(CommandLine.ExitCode.SOFTWARE); | ||
| assertThat(context.output().toString()).contains("Specified class isn't a valid connector type"); |
There was a problem hiding this comment.
I wanted to add an assertion about it actually showing the list of available connectors, but was having some trouble running the integration tests locally (containers were hanging on startup).
While less powerful, this test still guards against the NPE addressed by this PR.
There was a problem hiding this comment.
Is that container issue on Mac M1? If so, I've recently pushed an update which seems to help for the Kafka image, but Connect still seems slow. It's not quite clear to my why, as the Debezium 2.0 images have an Arm flaviour. Perhaps Testcontainers is not pulling that in for some reason?
There was a problem hiding this comment.
It is indeed on M1!
I've taken another stab at this on the latest main and am no longer seeing these issues. I thought I'd pulled the latest main before creating the branch for this PR, but maybe not?
Either way, filed #302 to add this missing test coverage and (of course 🙃) fix a bug that it unearthed.
There was a problem hiding this comment.
It is indeed on M1!
I've taken another stab at this on the latest main and am no longer seeing these issues.
Happy to hear! One thing we could do to further speed things up a bit is to use the debezium-base image (i.e. empty KC) rather than debezium, as scanning the plug-in path definitely takes some time. That'd require to adjust a few tests though, e.g. on expected connector plug-ins.
There was a problem hiding this comment.
Logged #303 for this.
|
Applied; thank you so much, @C0urante! |
Addresses #295