Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add .spec.path field to KCLRun resource #68

Open
ron1 opened this issue May 23, 2024 · 1 comment
Open

[Feature] Add .spec.path field to KCLRun resource #68

ron1 opened this issue May 23, 2024 · 1 comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@ron1
Copy link

ron1 commented May 23, 2024

Feature Request

Describe the feature you'd like:
I would like to deploy three different configs of a workload to different environments, prod, qa, and dev. The configuration of different environments is maintained by KCL code where different environments correspond to different folders. Currently, I believe such a deployment would require 3 different Flux GitRepository resources and 3 accompanying KCLRun resources. Adding field .spec.path to the KCLRun resource would give it comparable functionality to that offered by the Flux Kustomization resource described here: https://fluxcd.io/flux/components/kustomize/kustomizations/#path.

@ron1 ron1 changed the title Add spec.path field to KCLRun resource [Feature] Add spec.path field to KCLRun resource May 23, 2024
@ron1 ron1 changed the title [Feature] Add spec.path field to KCLRun resource [Feature] Add .spec.path field to KCLRun resource May 23, 2024
@Peefy
Copy link
Contributor

Peefy commented May 23, 2024

Hello. Thanks for the feature request #69, #68 and your use cases.

Essentially, there are two GitOps approaches here.

  1. Upload KCL compiled artifacts (usually YAML that satisfies the Kubernetes specifications) to OCI through CI, and then publish them through Flux OCIRepository and Kustomization resources
  2. Simply using KCLRun resources and Flux GitRepository resources for publishing, of course, this requires the ability of the flux kcl controller, as mentioned in this issue. However, this does not mean that complete redevelopment is required, only importing the package of the flux kustomize controller for consumption.

In short, this is a reasonable requirement, PRs also welcome. ❤️

@Peefy Peefy added help wanted Extra attention is needed good first issue Good for newcomers labels May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants