Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix typo ngnix to nginx #203

Merged
merged 1 commit into from Nov 12, 2023
Merged

fix: fix typo ngnix to nginx #203

merged 1 commit into from Nov 12, 2023

Conversation

cr7258
Copy link
Contributor

@cr7258 cr7258 commented Nov 11, 2023

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

fix typo ngnix to nginx.

related PRs:
kcl-lang/modules#67
kcl-lang/examples#1
#203
kcl-lang/krm-kcl#23
kcl-lang/kubectl-kcl#11

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

Copy link

github-actions bot commented Nov 11, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

Signed-off-by: chengzw <chengzw258@163.com>
@cr7258
Copy link
Contributor Author

cr7258 commented Nov 11, 2023

I have read the CLA Document and I hereby sign the CLA

@cr7258 cr7258 changed the title fix typo ngnix to nginx fix: fix typo ngnix to nginx Nov 11, 2023
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Catch!

@Peefy Peefy merged commit 05a3424 into kcl-lang:main Nov 12, 2023
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants