Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some test cases failed to pass in the docker image. #79

Closed
zong-zhe opened this issue Jun 7, 2022 · 3 comments · Fixed by #71
Closed

Some test cases failed to pass in the docker image. #79

zong-zhe opened this issue Jun 7, 2022 · 3 comments · Fixed by #71
Assignees
Labels
bug Something isn't working

Comments

@zong-zhe
Copy link
Contributor

zong-zhe commented Jun 7, 2022

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

Restore the "kclvm/runner/test.rs/fn test_kclvm_runner_execute()" method that has been commented out.
In the KCLVM

make sh-in-docker
cd kclvm/runner
cargo test -- --nocapture

2. What did you expect to see? (Required)

running 1 test
test tests::test_kclvm_runner_execute ... ok

test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 7.10s

3. What did you see instead (Required)

running 1 test
thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: Os { code: 2, kind: NotFound, message: "No such file or directory" }', src/command.rs:391:66
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

src/command.rs:391:66

let txt_path = std::path::Path::new(&executable_root)
      .join(if Self::is_windows() { "libs" } else { "lib" })
      .join("rust-libstd-name.txt");
391 ------>  let rust_libstd_name = std::fs::read_to_string(txt_path).unwrap();
                                                                     ^ 66

Cannot found the file "rust-libstd-name.txt".

4. What is your KusionStack components version? (Required)

kclvm version is 0.4.2; checksum: e07ed7af0d9bd1e86a3131714e4bd20c

@zong-zhe zong-zhe added the bug Something isn't working label Jun 7, 2022
@zong-zhe zong-zhe added this to the v0.4.3 Release milestone Jun 7, 2022
@zong-zhe
Copy link
Contributor Author

zong-zhe commented Jun 7, 2022

Method “kclvm/runner/test.rs/fn test_kclvm_runner_execute()" is in branch "refactor/zong-zhe/add_eval_to_kclvm_runner".

zong-zhe pushed a commit that referenced this issue Jun 7, 2022
  1. Encapsulated method "emit_code" into "lock_ll_file_and_gen_dylib" to
     reduce repetitive code in kclvm-runner/KclvmAssembler.gen_dylibs().
  2. In order to support reuse and simplify the structure of Method "gen_dylibs()",
     encapsulates some operations of cleaning file paths.
  3. Due to issue #79, some test cases are temporarily commented out

  fix #67
zong-zhe pushed a commit that referenced this issue Jun 7, 2022
  1. Encapsulated method "emit_code" into "lock_ll_file_and_gen_dylib" to
     reduce repetitive code in kclvm-runner/KclvmAssembler.gen_dylibs().
  2. In order to support reuse and simplify the structure of Method "gen_dylibs()",
     encapsulates some operations of cleaning file paths.
  3. Due to issue #79, some test cases are temporarily commented out

  fix #67
@Peefy
Copy link
Contributor

Peefy commented Jun 8, 2022

I have not reproduced this error.

@zong-zhe
Copy link
Contributor Author

I add “println!()” to show the value of "txt_path" at runtime.
截屏2022-06-10 08 51 29

The directory where file "rust-libstd-name.txt" is located is “_build/dist/ubuntu/kclvm/lib/rust-libstd-name.txt”.

zong-zhe pushed a commit that referenced this issue Jun 10, 2022
  1. Encapsulated method "emit_code" into "lock_ll_file_and_gen_dylib" to
     reduce repetitive code in kclvm-runner/KclvmAssembler.gen_dylibs().
  2. In order to support reuse and simplify the structure of Method "gen_dylibs()",
     encapsulates some operations of cleaning file paths.
  3. Due to issue #79, some test cases are temporarily commented out

  fix #67

  refactor(kclvm-runner): decouping assembler and llvm.

  1. Decoupling the assembler and llvm.
  2. The assembling LLVM IR into a dynamic link library is encapsulated into "LlvmLibAssembler" separately.
  3. Add trait "LibAssembler" to describe the interface "KclvmLibAssembler" should have.
     If other intermediate code is added in the future, the corresponding assembler must implement this trait.
  4. Struct "LlvmLibAssembler" is provided in "KclvmLibAssembler".
     "KclvmLibAssembler" is an enum that implements trait "LibAssembler".
     "KclvmLibAssembler" is responsible for the compilation of a single kcl file in one thread.
, 5. "KclvmAssembler" is responsible for the concurrent compilation of multiple kcl files.
  6. "KclvmAssembler" will call the method in "KclvmLibAssembler" to generate a dynamic link library
     for a single kcl file in each thread of concurrent compilation.

  fix #67
zong-zhe pushed a commit that referenced this issue Jun 10, 2022
  1. Encapsulated method "emit_code" into "lock_ll_file_and_gen_dylib" to
     reduce repetitive code in kclvm-runner/KclvmAssembler.gen_dylibs().
  2. In order to support reuse and simplify the structure of Method "gen_dylibs()",
     encapsulates some operations of cleaning file paths.
  3. Due to issue #79, some test cases are temporarily commented out

  fix #67

  refactor(kclvm-runner): decouping assembler and llvm.

  1. Decoupling the assembler and llvm.
  2. The assembling LLVM IR into a dynamic link library is encapsulated into "LlvmLibAssembler" separately.
  3. Add trait "LibAssembler" to describe the interface "KclvmLibAssembler" should have.
     If other intermediate code is added in the future, the corresponding assembler must implement this trait.
  4. Struct "LlvmLibAssembler" is provided in "KclvmLibAssembler".
     "KclvmLibAssembler" is an enum that implements trait "LibAssembler".
     "KclvmLibAssembler" is responsible for the compilation of a single kcl file in one thread.
, 5. "KclvmAssembler" is responsible for the concurrent compilation of multiple kcl files.
  6. "KclvmAssembler" will call the method in "KclvmLibAssembler" to generate a dynamic link library
     for a single kcl file in each thread of concurrent compilation.

  fix #67
Peefy added a commit that referenced this issue Jun 13, 2022
      1. Encapsulated method "emit_code" into "lock_ll_file_and_gen_dylib" to
         reduce repetitive code in kclvm-runner/KclvmAssembler.gen_dylibs().
      2. In order to support reuse and simplify the structure of Method "gen_dylibs()",
         encapsulates some operations of cleaning file paths.
      3. Due to issue #79, some test cases are temporarily commented out

      fix #67

      refactor(kclvm-runner): decouping assembler and llvm.

      1. Decoupling the assembler and llvm.
      2. The assembling LLVM IR into a dynamic link library is encapsulated into "LlvmLibAssembler" separately.
      3. Add trait "LibAssembler" to describe the interface "KclvmLibAssembler" should have.
         If other intermediate code is added in the future, the corresponding assembler must implement this trait.
      4. Struct "LlvmLibAssembler" is provided in "KclvmLibAssembler".
         "KclvmLibAssembler" is an enum that implements trait "LibAssembler".
         "KclvmLibAssembler" is responsible for the compilation of a single kcl file in one thread.
    , 5. "KclvmAssembler" is responsible for the concurrent compilation of multiple kcl files.
      6. "KclvmAssembler" will call the method in "KclvmLibAssembler" to generate a dynamic link library
         for a single kcl file in each thread of concurrent compilation.

      fix #67
Peefy added a commit that referenced this issue Jun 13, 2022
      1. Encapsulated method "emit_code" into "lock_ll_file_and_gen_dylib" to
         reduce repetitive code in kclvm-runner/KclvmAssembler.gen_dylibs().
      2. In order to support reuse and simplify the structure of Method "gen_dylibs()",
         encapsulates some operations of cleaning file paths.
      3. Due to issue #79, some test cases are temporarily commented out

      fix #67

      refactor(kclvm-runner): decouping assembler and llvm.

      1. Decoupling the assembler and llvm.
      2. The assembling LLVM IR into a dynamic link library is encapsulated into "LlvmLibAssembler" separately.
      3. Add trait "LibAssembler" to describe the interface "KclvmLibAssembler" should have.
         If other intermediate code is added in the future, the corresponding assembler must implement this trait.
      4. Struct "LlvmLibAssembler" is provided in "KclvmLibAssembler".
         "KclvmLibAssembler" is an enum that implements trait "LibAssembler".
         "KclvmLibAssembler" is responsible for the compilation of a single kcl file in one thread.
    , 5. "KclvmAssembler" is responsible for the concurrent compilation of multiple kcl files.
      6. "KclvmAssembler" will call the method in "KclvmLibAssembler" to generate a dynamic link library
         for a single kcl file in each thread of concurrent compilation.

      fix #67
Peefy added a commit that referenced this issue Jun 14, 2022
1. Encapsulated method "emit_code" into "lock_ll_file_and_gen_dylib" to
   reduce repetitive code in kclvm-runner/KclvmAssembler.gen_dylibs().
2. In order to support reuse and simplify the structure of Method "gen_dylibs()",
   encapsulates some operations of cleaning file paths.
3. Due to issue #79, some test cases are temporarily commented out

fix #67

refactor(kclvm-runner): decouping assembler and llvm.

1. Decoupling the assembler and llvm.
2. The assembling LLVM IR into a dynamic link library is encapsulated into "LlvmLibAssembler" separately.
3. Add trait "LibAssembler" to describe the interface "KclvmLibAssembler" should have.
   If other intermediate code is added in the future, the corresponding assembler must implement this trait.
4. Struct "LlvmLibAssembler" is provided in "KclvmLibAssembler".
   "KclvmLibAssembler" is an enum that implements trait "LibAssembler".
   "KclvmLibAssembler" is responsible for the compilation of a single kcl file in one thread.
, 5. "KclvmAssembler" is responsible for the concurrent compilation of multiple kcl files.
6. "KclvmAssembler" will call the method in "KclvmLibAssembler" to generate a dynamic link library
   for a single kcl file in each thread of concurrent compilation.

fix #67
Peefy added a commit that referenced this issue Jun 15, 2022
    1. Encapsulated method "emit_code" into "lock_ll_file_and_gen_dylib" to
       reduce repetitive code in kclvm-runner/KclvmAssembler.gen_dylibs().
    2. In order to support reuse and simplify the structure of Method "gen_dylibs()",
       encapsulates some operations of cleaning file paths.
    3. Due to issue #79, some test cases are temporarily commented out
    2. In order to support reuse and simplify the structure of Method "gen_dylibs()",
       encapsulates some operations of cleaning file paths.
    3. Due to issue #79, some test cases are temporarily commented out

    fix #67

    refactor(kclvm-runner): decouping assembler and llvm.

    1. Decoupling the assembler and llvm.
    2. The assembling LLVM IR into a dynamic link library is encapsulated into "LlvmLibAssembler" separately.
    3. Add trait "LibAssembler" to describe the interface "KclvmLibAssembler" should have.
       If other intermediate code is added in the future, the corresponding assembler must implement this trait.
    4. Struct "LlvmLibAssembler" is provided in "KclvmLibAssembler".
       "KclvmLibAssembler" is an enum that implements trait "LibAssembler".
       "KclvmLibAssembler" is responsible for the compilation of a single kcl file in one thread.
    , 5. "KclvmAssembler" is responsible for the concurrent compilation of multiple kcl files.
    6. "KclvmAssembler" will call the method in "KclvmLibAssembler" to generate a dynamic link library
       for a single kcl file in each thread of concurrent compilation.

    fix #67
Peefy added a commit that referenced this issue Jun 15, 2022
        1. Encapsulated method "emit_code" into "lock_ll_file_and_gen_dylib" to
           reduce repetitive code in kclvm-runner/KclvmAssembler.gen_dylibs().
        2. In order to support reuse and simplify the structure of Method "gen_dylibs()",
           encapsulates some operations of cleaning file paths.
        3. Due to issue #79, some test cases are temporarily commented out
        2. In order to support reuse and simplify the structure of Method "gen_dylibs()",
           encapsulates some operations of cleaning file paths.
        3. Due to issue #79, some test cases are temporarily commented out

        fix #67

        refactor(kclvm-runner): decouping assembler and llvm.

        1. Decoupling the assembler and llvm.
        2. The assembling LLVM IR into a dynamic link library is encapsulated into "LlvmLibAssembler" separately.
        3. Add trait "LibAssembler" to describe the interface "KclvmLibAssembler" should have.
           If other intermediate code is added in the future, the corresponding assembler must implement this trait.
        4. Struct "LlvmLibAssembler" is provided in "KclvmLibAssembler".
           "KclvmLibAssembler" is an enum that implements trait "LibAssembler".
           "KclvmLibAssembler" is responsible for the compilation of a single kcl file in one thread.
        , 5. "KclvmAssembler" is responsible for the concurrent compilation of multiple kcl files.
        6. "KclvmAssembler" will call the method in "KclvmLibAssembler" to generate a dynamic link library
           for a single kcl file in each thread of concurrent compilation.

        fix #67
Peefy added a commit that referenced this issue Jun 16, 2022
            1. Encapsulated method "emit_code" into "lock_ll_file_and_gen_dylib" to
               reduce repetitive code in kclvm-runner/KclvmAssembler.gen_dylibs().
            2. In order to support reuse and simplify the structure of Method "gen_dylibs()",
               encapsulates some operations of cleaning file paths.
            3. Due to issue #79, some test cases are temporarily commented out
            2. In order to support reuse and simplify the structure of Method "gen_dylibs()",
               encapsulates some operations of cleaning file paths.
            3. Due to issue #79, some test cases are temporarily commented out

            fix #67

            refactor(kclvm-runner): decouping assembler and llvm.

            1. Decoupling the assembler and llvm.
            2. The assembling LLVM IR into a dynamic link library is encapsulated into "LlvmLibAssembler" separately.
            3. Add trait "LibAssembler" to describe the interface "KclvmLibAssembler" should have.
               If other intermediate code is added in the future, the corresponding assembler must implement this trait.
            4. Struct "LlvmLibAssembler" is provided in "KclvmLibAssembler".
               "KclvmLibAssembler" is an enum that implements trait "LibAssembler".
               "KclvmLibAssembler" is responsible for the compilation of a single kcl file in one thread.
            , 5. "KclvmAssembler" is responsible for the concurrent compilation of multiple kcl files.
            6. "KclvmAssembler" will call the method in "KclvmLibAssembler" to generate a dynamic link library
               for a single kcl file in each thread of concurrent compilation.

            fix #67
Peefy added a commit that referenced this issue Jun 20, 2022
                1. Encapsulated method "emit_code" into "lock_ll_file_and_gen_dylib" to
                   reduce repetitive code in kclvm-runner/KclvmAssembler.gen_dylibs().
                2. In order to support reuse and simplify the structure of Method "gen_dylibs()",
                   encapsulates some operations of cleaning file paths.
                3. Due to issue #79, some test cases are temporarily commented out
                2. In order to support reuse and simplify the structure of Method "gen_dylibs()",
                   encapsulates some operations of cleaning file paths.
                3. Due to issue #79, some test cases are temporarily commented out

                fix #67

                refactor(kclvm-runner): decouping assembler and llvm.

                1. Decoupling the assembler and llvm.
                2. The assembling LLVM IR into a dynamic link library is encapsulated into "LlvmLibAssembler" separately.
                3. Add trait "LibAssembler" to describe the interface "KclvmLibAssembler" should have.
                   If other intermediate code is added in the future, the corresponding assembler must implement this trait.
                4. Struct "LlvmLibAssembler" is provided in "KclvmLibAssembler".
                   "KclvmLibAssembler" is an enum that implements trait "LibAssembler".
                   "KclvmLibAssembler" is responsible for the compilation of a single kcl file in one thread.
                , 5. "KclvmAssembler" is responsible for the concurrent compilation of multiple kcl files.
                6. "KclvmAssembler" will call the method in "KclvmLibAssembler" to generate a dynamic link library
                   for a single kcl file in each thread of concurrent compilation.

                fix #67
@Peefy Peefy removed their assignment Jun 20, 2022
Peefy added a commit that referenced this issue Jun 20, 2022
                    1. Encapsulated method "emit_code" into "lock_ll_file_and_gen_dylib" to
                       reduce repetitive code in kclvm-runner/KclvmAssembler.gen_dylibs().
                    2. In order to support reuse and simplify the structure of Method "gen_dylibs()",
                       encapsulates some operations of cleaning file paths.
                    3. Due to issue #79, some test cases are temporarily commented out
                    2. In order to support reuse and simplify the structure of Method "gen_dylibs()",
                       encapsulates some operations of cleaning file paths.
                    3. Due to issue #79, some test cases are temporarily commented out

                    fix #67

                    refactor(kclvm-runner): decouping assembler and llvm.

                    1. Decoupling the assembler and llvm.
                    2. The assembling LLVM IR into a dynamic link library is encapsulated into "LlvmLibAssembler" separately.
                    3. Add trait "LibAssembler" to describe the interface "KclvmLibAssembler" should have.
                       If other intermediate code is added in the future, the corresponding assembler must implement this trait.
                    4. Struct "LlvmLibAssembler" is provided in "KclvmLibAssembler".
                       "KclvmLibAssembler" is an enum that implements trait "LibAssembler".
                       "KclvmLibAssembler" is responsible for the compilation of a single kcl file in one thread.
                    , 5. "KclvmAssembler" is responsible for the concurrent compilation of multiple kcl files.
                    6. "KclvmAssembler" will call the method in "KclvmLibAssembler" to generate a dynamic link library
                       for a single kcl file in each thread of concurrent compilation.

                    fix #67
Peefy added a commit that referenced this issue Jul 11, 2022
…cuting in kclvm/lib.rs into kclvm-runner (#71)

* refactor(kclvm-runner): encapsulate dylib generating, linking and executing in kclvm/lib.rs into kclvm-runner

The assembler and linker of the current version of the compiler are not separately packaged.
In order to support the reuse of modules such as dylibs generating,linking and executing,
This modification separates dylibs generating,and encapsulate them individually into KclvmAssembler and KclvmLinker.

Encapsulate dylibs generating, linking and executing into kclvm-runner/assembler.rs and kclvm-runner/linker.rs.
Add struct "KclvmAssembler" in kclvm-runner/assembler.rs to provide method "gen_dylibs" for dylibs generating.
Add struct "KclvmLinker" in kclvm-runner/linker.rs to provide method "link_all_dylibs" for dylib linking.
Add method "execute" in kclvm-runner/lib.rs to encapsulate dylibs generating(gen_dylib), dylib linking(link_all_dylib) and running(runner.run) together.

fix #67

* chore:  bump plugins submodule to 23fc581d (#64)

* refactor(kclvm-runner): merge main and refacor kclvm-runner.

                    1. Encapsulated method "emit_code" into "lock_ll_file_and_gen_dylib" to
                       reduce repetitive code in kclvm-runner/KclvmAssembler.gen_dylibs().
                    2. In order to support reuse and simplify the structure of Method "gen_dylibs()",
                       encapsulates some operations of cleaning file paths.
                    3. Due to issue #79, some test cases are temporarily commented out
                    2. In order to support reuse and simplify the structure of Method "gen_dylibs()",
                       encapsulates some operations of cleaning file paths.
                    3. Due to issue #79, some test cases are temporarily commented out

                    fix #67

                    refactor(kclvm-runner): decouping assembler and llvm.

                    1. Decoupling the assembler and llvm.
                    2. The assembling LLVM IR into a dynamic link library is encapsulated into "LlvmLibAssembler" separately.
                    3. Add trait "LibAssembler" to describe the interface "KclvmLibAssembler" should have.
                       If other intermediate code is added in the future, the corresponding assembler must implement this trait.
                    4. Struct "LlvmLibAssembler" is provided in "KclvmLibAssembler".
                       "KclvmLibAssembler" is an enum that implements trait "LibAssembler".
                       "KclvmLibAssembler" is responsible for the compilation of a single kcl file in one thread.
                    , 5. "KclvmAssembler" is responsible for the concurrent compilation of multiple kcl files.
                    6. "KclvmAssembler" will call the method in "KclvmLibAssembler" to generate a dynamic link library
                       for a single kcl file in each thread of concurrent compilation.

                    fix #67

* Merge branch 'main' into refactor/zong-zhe/add_eval_to_kclvm_runner

* add kclvm path in ci for ubuntu

* refactor(kclvm-runner): encapsulate lib generating, linking and executing into kclvm-runner.

1. Encapsulate generating of libs  in "kclvm/src/lib.rs" and "kclvm/src/main.rs"  into "kclvm/runner/assembler.rs".
2. Encapsulate linking of libs in "kclvm/src/lib.rs" and "kclvm/src/main.rs" into "kclvm/runner/linker.rs"
3. Encapsulate executing of libs  in "kclvm/src/lib.rs" and "kclvm/src/main.rs" into "kclvm/runner/lib.rs".
4. A timer is added during the concurrent multi-file compilation to prevent KCLVM locked due to child thread panic.

fix #67 #106 #82

Co-authored-by: Peefy <xpf6677@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
3 participants