-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: formatting support for multiple if statements #1041
Merged
Peefy
merged 3 commits into
kcl-lang:main
from
shashank-iitbhu:nested-ifStmt-formatting-fix
Feb 17, 2024
Merged
fix: formatting support for multiple if statements #1041
Peefy
merged 3 commits into
kcl-lang:main
from
shashank-iitbhu:nested-ifStmt-formatting-fix
Feb 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shashank Mittal <shashank.mittal.mec22@itbhu.ac.in>
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
recheck |
Peefy
added a commit
to kcl-lang/cla.db
that referenced
this pull request
Feb 15, 2024
Pull Request Test Coverage Report for Build 7934340233Details
💛 - Coveralls |
@Peefy Any idea why these workflows are failing? went through the logs, I think these workflows need to be updated. |
Peefy
reviewed
Feb 16, 2024
Signed-off-by: Shashank Mittal <shashank.mittal.mec22@itbhu.ac.in>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Does this PR affect any open issues?(Y/N) and add issue references:
fixes #1039
2. What is the scope of this PR (e.g. component or file name):
kclvm/ast_pretty/src/node.rs
3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):
Screen.Recording.2024-02-16.at.3.34.02.AM.mov
if_stmt.orelse
isVec<NodeRef<Stmt>>
, so to format the code correctly for multiple if statements inside an else block, had to iterate through all the elements ofif_stmt.orelse
.4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):
5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links: