Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

design doc for kcl watcher #1119

Merged
merged 1 commit into from
Mar 27, 2024
Merged

design doc for kcl watcher #1119

merged 1 commit into from
Mar 27, 2024

Conversation

octonawish-akcodes
Copy link
Contributor

@octonawish-akcodes octonawish-akcodes commented Mar 8, 2024 •
edited

Here are my thoughts about the KCL watcher system.
Relate comments for context:
#1118 (comment)
#1118 (comment)
cc @Peefy @zong-zhe @He1pa

Target Issue #1132

@coveralls
Copy link
Collaborator

coveralls commented Mar 8, 2024 •
edited

Pull Request Test Coverage Report for Build 8446212161

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 72.046%
Totals Coverage Status
Change from base Build 8438341163: 0.0%
Covered Lines: 46507
Relevant Lines: 64552
💛 - Coveralls

@octonawish-akcodes octonawish-akcodes mentioned this pull request Mar 13, 2024
Closed
@Peefy Peefy added the design label Mar 20, 2024
@Peefy Peefy added this to the v0.9.0 Release milestone Mar 20, 2024
@octonawish-akcodes
design doc for kcl watcher
842ac02 
Signed-off-by: Abhishek Kumar <abhishek22512@gmail.com>
Peefy
Peefy approved these changes Mar 27, 2024
View reviewed changes
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit ff86214 into kcl-lang:main Mar 27, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Peefy Peefy Peefy approved these changes

Assignees
No one assigned
Labels
design
Projects
None yet
Milestone
v0.9.0 Release
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@octonawish-akcodes @coveralls @Peefy