Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed AdderessSpace issue with inkwell #400

Merged
merged 1 commit into from
Feb 3, 2023

Conversation

thinkrapido
Copy link
Contributor

@thinkrapido thinkrapido commented Feb 2, 2023

Fixed #398

enum AddressSpace in inkwell has changed to struct

@github-actions
Copy link

github-actions bot commented Feb 2, 2023

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request

@coveralls
Copy link
Collaborator

coveralls commented Feb 2, 2023

Pull Request Test Coverage Report for Build 4076615119

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 90.562%

Totals Coverage Status
Change from base Build 4050370946: 0.0%
Covered Lines: 1612
Relevant Lines: 1780

💛 - Coveralls

@Peefy Peefy added the refactor label Feb 3, 2023
@Peefy Peefy added this to the v0.4.5 Release milestone Feb 3, 2023
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@zong-zhe zong-zhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit 36e3d37 into kcl-lang:main Feb 3, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Feb 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cargo update breaks build
4 participants