Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: the checksum calculation during compilation is removed #314

Merged
merged 6 commits into from
May 23, 2024

Conversation

zong-zhe
Copy link
Contributor

@zong-zhe zong-zhe commented May 10, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

re #295
close #314
close #328

2. What is the scope of this PR (e.g. component or file name):

  1. Removed all processes that require local checksum calculations.
  2. All the checksum of dependencies are required from oci manifests.
  3. Only the process of downloading packages from oci registry now requires checksum checks.

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@zong-zhe zong-zhe added the enhancement New feature or request label May 10, 2024
@zong-zhe zong-zhe requested a review from Peefy May 10, 2024 08:20
@zong-zhe zong-zhe self-assigned this May 10, 2024
@coveralls
Copy link

coveralls commented May 10, 2024

Pull Request Test Coverage Report for Build 9208594875

Details

  • 141 of 207 (68.12%) changed or added relevant lines in 6 files are covered.
  • 52 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.6%) to 43.301%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/cmd/cmd_add.go 0 1 0.0%
pkg/package/modfile.go 4 8 50.0%
pkg/client/client.go 131 192 68.23%
Files with Coverage Reduction New Missed Lines %
pkg/client/client.go 52 57.22%
Totals Coverage Status
Change from base Build 9175536317: -0.6%
Covered Lines: 2469
Relevant Lines: 5702

💛 - Coveralls

pkg/client/client.go Show resolved Hide resolved
pkg/api/kpm_pkg.go Outdated Show resolved Hide resolved
pkg/client/client.go Show resolved Hide resolved
pkg/client/client.go Outdated Show resolved Hide resolved
pkg/client/client.go Outdated Show resolved Hide resolved
pkg/client/client.go Show resolved Hide resolved
pkg/package/modfile.go Outdated Show resolved Hide resolved
pkg/package/modfile.go Outdated Show resolved Hide resolved
Signed-off-by: zongz <zongzhe1024@163.com>
Signed-off-by: zongz <zongzhe1024@163.com>
Signed-off-by: zongz <zongzhe1024@163.com>
Signed-off-by: zongz <zongzhe1024@163.com>
Signed-off-by: zongz <zongzhe1024@163.com>
Signed-off-by: zongz <zongzhe1024@163.com>
pkg/client/client.go Outdated Show resolved Hide resolved
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit aa19024 into kcl-lang:main May 23, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

KCL drastically slows down when Enhancement: kpm add command displaying optimization
3 participants