Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 'kpm run' supports compile the kcl package from oci registry. #47

Merged
merged 3 commits into from
Apr 24, 2023

Conversation

zong-zhe
Copy link
Contributor

@zong-zhe zong-zhe commented Apr 21, 2023

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

issue #46 and #42

2. What is the scope of this PR (e.g. component or file name):

kpm/pkg/cmd
kpm/pkg/oci

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

'kpm run' supports compile the kcl package from oci registry.

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@zong-zhe zong-zhe added the enhancement New feature or request label Apr 21, 2023
@zong-zhe zong-zhe self-assigned this Apr 21, 2023
@coveralls
Copy link

coveralls commented Apr 21, 2023

Pull Request Test Coverage Report for Build 4783297815

  • 16 of 192 (8.33%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-4.0%) to 40.954%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/utils/utils.go 0 1 0.0%
pkg/oci/oci.go 0 48 0.0%
pkg/cmd/cmd_run.go 16 72 22.22%
pkg/opt/opt.go 0 71 0.0%
Totals Coverage Status
Change from base Build 4761499735: -4.0%
Covered Lines: 575
Relevant Lines: 1404

💛 - Coveralls

pkg/cmd/cmd_run.go Outdated Show resolved Hide resolved
pkg/cmd/cmd_run.go Outdated Show resolved Hide resolved
pkg/cmd/cmd_run.go Outdated Show resolved Hide resolved
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit 6b49fca into kcl-lang:main Apr 24, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Apr 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants