Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write library by temporary file creation to avoid in-place modification executed library #74

Merged
merged 1 commit into from
May 13, 2024

Conversation

bozaro
Copy link
Contributor

@bozaro bozaro commented May 13, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references:

  • N
  • Y

Fix #73

2. What is the scope of this PR (e.g. component or file name):

  • util.go

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

An application using KCL does not crash after installing a different version of KCL.

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

See #73

…on executed library

Signed-off-by: Artem V. Navrotskiy <bozaro@yandex.ru>
@Peefy Peefy merged commit 34b02b7 into kcl-lang:main May 13, 2024
5 of 8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 13, 2024
@bozaro bozaro deleted the safe-write-lib branch May 13, 2024 09:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Application with KCL native client crash after KCL updated by Go-binary
2 participants