feat: add Attributes keyword
#48
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: shruti2522 <shruti.apc01@gmail.com>
16 tasks
Peefy
reviewed
May 17, 2024
| @@ -28,7 +28,7 @@ | |||
| "keywords": { | |||
| "patterns": [{ | |||
| "name": "keyword.control.KCL", | |||
| "match": "\\b(as|assert|if|elif|else|lambda|for|import|schema|protocol|rule|mixin|check|and|in|is|not|or|all|any|map|filter|type)\\b" | |||
| "match": "\\b(as|assert|if|elif|else|lambda|for|import|schema|protocol|rule|mixin|check|and|in|is|not|or|all|any|map|filter|type|Attributes)\\b" | |||
There was a problem hiding this comment.
Attributes is not a keyword…
There was a problem hiding this comment.
I added it as a keyword since the pretest mentioned :
pretest only needs to implement keyword highlighting, such as schema, Attribute, str, int
There was a problem hiding this comment.
I think the pretest expect a new better hover content with highlighting instead of adding a highlighting for the original content. cc @He1pa
There was a problem hiding this comment.
Okay @Peefy, got it, I will update the code accordingly and push the changes soon.
|
attribute is not a keyword. I just use it to differentiate Hover from other parts of the content. Even Attribute is not required in hover content. You can also render the hovered content into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):
2. What is the scope of this PR (e.g. component or file name):
vscode-kcl/syntaxes/KCL.tmLanguage.json
3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):
Added
Attributeskeyword to kcl grammar to support syntax highlighting in hover.4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):
5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links: