Separated params for backup and tidy cronjobs - Fixes #3 #4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In manifests/config.pp the module creates a cronjob with the following oneliner:
command => "/usr/bin/find ${influxdb::backup_directory} -mtime +${influxdb::backup_keep} -type f -delete";
If backup_keep is set to 2, this creates something like:
/usr/bin/find /var/lib/influxdb/backups -mtime +2 -type f -delete
This is caused by the cronjobs for backup and tidy being created to run at the exact same time. In certain circumstances, this results in the the backup location running low on disk space, triggering "false alerts".
The solution introduced here separates parameters for both cron jobs, avoiding a race condition between the two cron jobs.