Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider enabling more linters #2539

Closed
vincepri opened this issue Jan 3, 2023 · 1 comment
Closed

Consider enabling more linters #2539

vincepri opened this issue Jan 3, 2023 · 1 comment
Labels
area/repo-health

Comments

@vincepri
Copy link
Contributor

vincepri commented Jan 3, 2023

In #2480 we introduced a set of new linters, .golangci.yaml file in the root directory contains a number of directives and exclusions under TODOs. We should consider:

  • Enabling more linters in the excluded list (like goconst)
  • Look at enabling more rules in revive
  • Remove some of the gosec excluded checks
@vincepri vincepri mentioned this issue Jan 3, 2023
Merged
@sttts
Copy link
Member

sttts commented Jan 10, 2023

Done in #2480

@sttts sttts closed this as completed Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/repo-health
Projects
kcp
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ncdc @sttts @vincepri