🌱 Update golangci-lint 1.50.1, add more linters #2480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
kind/api-change
|
Can we hold that until the workspace refactoring has merged? Fearing rebase hell. |
|
@sttts Absolutely, I forgot to put the hold after talking with Andy, I'll wait and do a rebase on your refactoring once it's ready /hold |
openshift-ci
bot
added
the
do-not-merge/hold
s-urbaniak
reviewed
Dec 14, 2022
openshift-merge-robot
added
needs-rebase
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
s-urbaniak
reviewed
Jan 3, 2023
s-urbaniak
reviewed
Jan 3, 2023
|
/lgtm |
ncdc
reviewed
Jan 3, 2023
|
Let me know if we'd prefer to have a single commit here, or keep them separate, happy to do either way |
|
/retest |
|
Don't think multiple commits will hurt anything - re-triggering the tests to clear flakes |
|
/lgtm |
ncdc
reviewed
Jan 4, 2023
pkg/cache/client/round_tripper.go
Outdated
| @@ -56,12 +56,12 @@ func WithShardNameFromContextRoundTripper(cfg *rest.Config) *rest.Config { | |||
| // It changes the URL path to target a shard from the context. | |||
| // | |||
| // For example given "amber" shard name in the context it will change | |||
| // apis/apis.kcp.io/v1alpha1/apiexports to /shards/amber/apis/apis.kcp.io/v1alpha1/apiexports | |||
| // apis/apis.kcp.dev/v1alpha1/apiexports to /shards/amber/apis/apis.kcp.dev/v1alpha1/apiexports. | |||
ncdc
reviewed
Jan 4, 2023
ncdc
reviewed
Jan 4, 2023
pkg/tunneler/listener.go
Outdated
| if err != nil { | ||
| klog.V(5).Infof("Can not create request %v", err) | ||
| return nil, err | ||
| } | ||
|
|
||
| klog.V(5).Infof("Listener creating connection to %s", connect) | ||
| res, err := ln.client.Do(req) | ||
| res, err := ln.client.Do(req) //nolint:bodyclose // Seems we're returning te connection with res.Body, caller closes it? |
There was a problem hiding this comment.
Suggested change
| res, err := ln.client.Do(req) //nolint:bodyclose // Seems we're returning te connection with res.Body, caller closes it? | |
| res, err := ln.client.Do(req) //nolint:bodyclose // Seems we're returning the connection with res.Body, caller closes it? |
ncdc
reviewed
Jan 4, 2023
Signed-off-by: Vince Prignano <vince@prigna.com>
Signed-off-by: Vince Prignano <vince@prigna.com>
Signed-off-by: Vince Prignano <vince@prigna.com>
Signed-off-by: Vince Prignano <vince@prigna.com>
openshift-merge-robot
removed
the
needs-rebase
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ncdc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates golanci-lint, adds many new linters, and fixes up a number of linter-found issues. For simplicity of review, the commits are split into multiple ones, although happy to squash them if needed.
Related issue(s)
Fixes #