✨ 📖 tmc: storage docs and apis #1971

guymguym · 2022-09-14T11:00:40Z

Signed-off-by: Guy Margalit guymguym@gmail.com

Summary

This is the first story of the storage epic - kcp-dev/contrib-tmc#112

Related issue(s)

openshift-ci · 2022-09-14T11:00:52Z

Hi @guymguym. Thanks for your PR.

I'm waiting for a kcp-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ncdc · 2022-09-14T12:13:30Z

/ok-to-test

pkg/apis/workload/v1alpha1/types.go

cooktheryan · 2022-10-02T16:33:08Z

@guymguym just bumping this with Andy's suggestions

docs/storage.md

davidfestal · 2022-10-03T09:35:53Z

/lgtm

guymguym · 2022-10-03T13:18:26Z

/hold

guymguym · 2022-10-05T10:29:50Z

/unhold

guymguym · 2022-10-05T10:31:34Z

Hey @davidfestal @sttts @ncdc
I would be happy if you could review and let me know how is this level of detail, and I will fix.
Thanks

.gitignore

docs/locations-and-scheduling.md

ncdc · 2022-10-05T20:08:53Z

docs/locations-and-scheduling.md

+This is the case with storage PVs, which are created on the workload cluster by a CSI driver.
+
+Unlike the `Sync` state, the `Upsync` state is exclusive, and only a single cluster can be upsyncing a resource to KCP.
+In addition, other clusters cannot be syncing down while the resource is upsyncing.


What is "clusters" here? Workspace?

ok I see the confusion, perhaps in this context it would be better to say "syncers"?

Yes, that's why I was asking - confusion 😄

does "syncers" help?

Hey @ncdc I reviewed today with @davidfestal and I think we resolved the confusion around my free use for the term "cluster".

I changed many occurences to SyncTarget and some others to pcluster. I hope that pcluster is a good term to represent the infrastructure aspects of the downstream cluster.

Signed-off-by: Guy Margalit <guymguym@gmail.com>

davidfestal · 2022-10-10T08:40:00Z

/approve

sttts · 2022-10-10T09:49:00Z

/approve

openshift-ci · 2022-10-10T09:54:23Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidfestal, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~docs/OWNERS~~ [davidfestal,sttts]
~~pkg/apis/OWNERS~~ [sttts]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 14, 2022

ncdc reviewed Sep 14, 2022

View reviewed changes

pkg/apis/workload/v1alpha1/types.go Outdated Show resolved Hide resolved

davidfestal reviewed Oct 3, 2022

View reviewed changes

docs/storage.md Outdated Show resolved Hide resolved

docs/storage.md Outdated Show resolved Hide resolved

docs/storage.md Outdated Show resolved Hide resolved

davidfestal marked this pull request as ready for review October 3, 2022 09:35

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 3, 2022

openshift-ci bot requested review from ncdc and stevekuznetsov October 3, 2022 09:35

openshift-ci bot assigned davidfestal Oct 3, 2022

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 3, 2022

davidfestal mentioned this pull request Oct 3, 2022

Epic: Storage volume scheduling and movement PoC kcp-dev/contrib-tmc#112

Open

16 tasks

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 3, 2022

guymguym force-pushed the guy-storage-docs branch from c9cb9dc to aafd6f9 Compare October 5, 2022 01:56

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 5, 2022

guymguym force-pushed the guy-storage-docs branch 3 times, most recently from d1a3755 to b1994d3 Compare October 5, 2022 10:29

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 5, 2022

guymguym requested a review from davidfestal October 5, 2022 10:32

guymguym force-pushed the guy-storage-docs branch from b1994d3 to 7d6ef9e Compare October 5, 2022 10:48

guymguym linked an issue Oct 5, 2022 that may be closed by this pull request

Storage - Define and document the new APIs - PVC, PV, labels, annotations, etc. #1979

Closed

ncdc reviewed Oct 5, 2022

View reviewed changes

.gitignore Outdated Show resolved Hide resolved

ncdc reviewed Oct 5, 2022

View reviewed changes

guymguym force-pushed the guy-storage-docs branch 3 times, most recently from 59b5e43 to 4c979fb Compare October 6, 2022 18:17

guymguym added 3 commits October 6, 2022 21:30

tmc: storage docs and apis

524b54a

Signed-off-by: Guy Margalit <guymguym@gmail.com>

Fixes after David's review

f1bce61

Signed-off-by: Guy Margalit <guymguym@gmail.com>

Fix Andy's suggestion

6979131

Signed-off-by: Guy Margalit <guymguym@gmail.com>

guymguym force-pushed the guy-storage-docs branch from 4c979fb to 6979131 Compare October 6, 2022 18:30

guymguym requested a review from sttts October 6, 2022 18:41

davidfestal approved these changes Oct 10, 2022

View reviewed changes

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 10, 2022

davidfestal assigned ncdc and sttts and unassigned davidfestal Oct 10, 2022

davidfestal added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 10, 2022

openshift-merge-robot merged commit 525b295 into kcp-dev:main Oct 10, 2022

kcp-ci-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 23, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

✨ 📖 tmc: storage docs and apis #1971

✨ 📖 tmc: storage docs and apis #1971

guymguym commented Sep 14, 2022

openshift-ci bot commented Sep 14, 2022

ncdc commented Sep 14, 2022

cooktheryan commented Oct 2, 2022

davidfestal commented Oct 3, 2022

guymguym commented Oct 3, 2022

guymguym commented Oct 5, 2022

guymguym commented Oct 5, 2022

ncdc Oct 5, 2022

guymguym Oct 5, 2022

ncdc Oct 5, 2022

guymguym Oct 5, 2022

ncdc Oct 6, 2022

guymguym Oct 6, 2022

guymguym Oct 6, 2022

davidfestal commented Oct 10, 2022

sttts commented Oct 10, 2022

openshift-ci bot commented Oct 10, 2022

✨ 📖 tmc: storage docs and apis #1971

✨ 📖 tmc: storage docs and apis #1971

Conversation

guymguym commented Sep 14, 2022

Summary

Related issue(s)

openshift-ci bot commented Sep 14, 2022

ncdc commented Sep 14, 2022

cooktheryan commented Oct 2, 2022

davidfestal commented Oct 3, 2022

guymguym commented Oct 3, 2022

guymguym commented Oct 5, 2022

guymguym commented Oct 5, 2022

ncdc Oct 5, 2022

Choose a reason for hiding this comment

guymguym Oct 5, 2022

Choose a reason for hiding this comment

ncdc Oct 5, 2022

Choose a reason for hiding this comment

guymguym Oct 5, 2022

Choose a reason for hiding this comment

ncdc Oct 6, 2022

Choose a reason for hiding this comment

guymguym Oct 6, 2022

Choose a reason for hiding this comment

guymguym Oct 6, 2022

Choose a reason for hiding this comment

davidfestal commented Oct 10, 2022

sttts commented Oct 10, 2022

openshift-ci bot commented Oct 10, 2022