✨ Add garbage collector controller #2112

astefanutti · 2022-09-30T17:18:03Z

Summary

This PR enables the garbage collector controller per workspace.

Related issue(s)

Fixes #191

openshift-ci · 2022-09-30T17:18:06Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

pkg/informer/delegating_event_handler.go

ncdc · 2022-10-17T17:14:10Z

@astefanutti would love to see this run through the full test suite in CI. To do that, you can make a temporary commit (we'll drop it later) that points to your fork of Kubernetes:

$ GITHUB_USER=astefanutti BRANCH=pr-gc hack/bump-k8s.sh

astefanutti · 2022-10-17T18:05:44Z

@ncdc sure, just added tmp commit.

pkg/indexers/indexers.go

pkg/informer/dynamic_discovery_shared_informer_factory.go

pkg/reconciler/garbagecollector/garbagecollector_controller.go

pkg/reconciler/kubequota/kubequota_controller.go

test/e2e/garbagecollector/garbagecollector_test.go

stevekuznetsov

This looks awesome! Thanks for doing that rebase.

pkg/informer/informer.go

pkg/reconciler/garbagecollector/garbagecollector_controller.go

pkg/server/controllers.go

ncdc · 2022-11-10T16:01:52Z

/unhold
/lgtm

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 30, 2022

astefanutti force-pushed the pr-gc branch from dcb6964 to a9862af Compare October 3, 2022 10:05

astefanutti mentioned this pull request Oct 4, 2022

UPSTREAM: <carry>: garbage collector monitors syncing kcp-dev/kubernetes#108

Merged

ncdc added this to the v0.10 milestone Oct 5, 2022

astefanutti marked this pull request as ready for review October 6, 2022 14:32

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 6, 2022

openshift-ci bot requested review from csams and qiujian16 October 6, 2022 14:32

astefanutti force-pushed the pr-gc branch 2 times, most recently from 216fc89 to b4ef5a0 Compare October 7, 2022 12:36

nrb reviewed Oct 13, 2022

View reviewed changes

pkg/informer/delegating_event_handler.go Outdated Show resolved Hide resolved

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 17, 2022

astefanutti force-pushed the pr-gc branch from 8e056fe to 8f590a2 Compare October 17, 2022 17:55

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 17, 2022

astefanutti force-pushed the pr-gc branch from 8f590a2 to 93354a0 Compare October 17, 2022 18:02

ncdc reviewed Oct 17, 2022

View reviewed changes

astefanutti force-pushed the pr-gc branch 2 times, most recently from 0c1e5ca to 5d46adb Compare October 19, 2022 14:17

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 20, 2022

astefanutti force-pushed the pr-gc branch from db07bbe to 76d0270 Compare October 20, 2022 08:21

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 20, 2022

astefanutti force-pushed the pr-gc branch from 76d0270 to d92b119 Compare October 20, 2022 09:51

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 22, 2022

astefanutti force-pushed the pr-gc branch from 7819338 to dd7d535 Compare October 24, 2022 10:07

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 24, 2022

stevekuznetsov reviewed Oct 24, 2022

View reviewed changes

astefanutti force-pushed the pr-gc branch from 0a8ef44 to 38ae344 Compare October 24, 2022 13:57

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 10, 2022

astefanutti force-pushed the pr-gc branch 2 times, most recently from ad16bbb to 2817b9d Compare November 10, 2022 15:26

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 10, 2022

astefanutti force-pushed the pr-gc branch from 2817b9d to e5e3284 Compare November 10, 2022 15:45

astefanutti added 5 commits November 10, 2022 16:48

go.mod: bump k8s

6b04013

Add garbage collector controller

e560419

Add default and projected APIs to GC ignored resources

1e8739f

Use shared dynamic discovery events to trigger GC monitors resync

4f2bb2b

Make sure garbage collector monitors are synced at least once

bcc8bf5

astefanutti force-pushed the pr-gc branch from e5e3284 to bbcd2c3 Compare November 10, 2022 15:50

astefanutti added 12 commits November 10, 2022 16:56

Add garbage collector controller e2e tests

2ad444c

Make sure quota monitors are synced at least once

f23fcfa

Use a single shared server in TestKubeQuotaCoreV1TypesFromBinding

96b9ad6

Use one client per parallel test to fix race in GC e2e tests

571eec9

Remove listCRDs function from GC and quota controllers

ec2748d

Add multi-versions CRD case to GC controller e2e tests

0e77285

Do not skip discovery when multiple CRDs are found in informer index

bb7732c

Simplified shared informer discovery data from built-in and CRD types

215ec89

Index all served versions in dynamic shared informer factory

4559622

Add second version owned resource to GC multi-versions e2e test

b86df43

GC: Use a workqueue to manage resync monitors

5c123e3

Implement RESTMapper by dynamic shared informer factory

4149c73

astefanutti force-pushed the pr-gc branch from bbcd2c3 to 4149c73 Compare November 10, 2022 15:57

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 10, 2022

openshift-ci bot assigned ncdc Nov 10, 2022

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 10, 2022

openshift-merge-robot merged commit 5ea4b92 into kcp-dev:main Nov 10, 2022

astefanutti deleted the pr-gc branch November 18, 2022 15:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

✨ Add garbage collector controller #2112

✨ Add garbage collector controller #2112

astefanutti commented Sep 30, 2022 •

edited

openshift-ci bot commented Sep 30, 2022

ncdc commented Oct 17, 2022 •

edited

astefanutti commented Oct 17, 2022 •

edited

stevekuznetsov left a comment

ncdc commented Nov 10, 2022

✨ Add garbage collector controller #2112

✨ Add garbage collector controller #2112

Conversation

astefanutti commented Sep 30, 2022 • edited

Summary

Related issue(s)

openshift-ci bot commented Sep 30, 2022

ncdc commented Oct 17, 2022 • edited

astefanutti commented Oct 17, 2022 • edited

stevekuznetsov left a comment

Choose a reason for hiding this comment

ncdc commented Nov 10, 2022

astefanutti commented Sep 30, 2022 •

edited

ncdc commented Oct 17, 2022 •

edited

astefanutti commented Oct 17, 2022 •

edited