Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃悰 Create VirtualWorkSpaceURL on first APIBinding #2135

Merged
merged 1 commit into from
Oct 11, 2022
Merged

馃悰 Create VirtualWorkSpaceURL on first APIBinding #2135

merged 1 commit into from
Oct 11, 2022

Conversation

nrb
Copy link
Contributor

@nrb nrb commented Oct 5, 2022

Summary

Defer creating an APIExport's first virtualWorkspaceURL until the first APIBinding is created.

Related issue(s)

Fixes #1183

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 5, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 5, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

ncdc
ncdc reviewed Oct 6, 2022
View reviewed changes
pkg/indexers/apibinding.go Outdated Show resolved Hide resolved
@nrb nrb force-pushed the fix-1183 branch 2 times, most recently from 4210ad7 to 29bdfc7 Compare October 7, 2022 18:57
@nrb nrb marked this pull request as ready for review October 7, 2022 19:48
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 7, 2022
@nrb nrb force-pushed the fix-1183 branch 3 times, most recently from 1c40671 to 3ccb73a Compare October 10, 2022 20:24
ncdc
ncdc reviewed Oct 11, 2022
View reviewed changes
pkg/reconciler/apis/apiexport/apiexport_controller.go Outdated Show resolved Hide resolved
pkg/indexers/apiexport.go Outdated Show resolved Hide resolved
pkg/reconciler/apis/apiexport/apiexport_controller.go Outdated Show resolved Hide resolved
pkg/reconciler/apis/apiexport/apiexport_reconcile.go Outdated Show resolved Hide resolved
pkg/reconciler/apis/apiexport/apiexport_reconcile.go Outdated Show resolved Hide resolved
@nrb
Create VW URLs on first APIBinding
5fe0085 
Signed-off-by: Nolan Brubaker <nolan@nbrubaker.com>
@nrb
Copy link
Contributor Author

nrb commented Oct 11, 2022

/retest

Possible flake kcp-dev/contrib-tmc#89

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 11, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 11, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ncdc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 11, 2022
@openshift-merge-robot openshift-merge-robot merged commit 7f75296 into kcp-dev:main Oct 11, 2022
@nrb nrb mentioned this pull request Oct 12, 2022
Open
@nrb nrb deleted the fix-1183 branch October 12, 2022 19:25
@fgiloux fgiloux mentioned this pull request Oct 13, 2022
Open
@astefanutti astefanutti mentioned this pull request Nov 24, 2022
Merged
@kcp-ci-bot kcp-ci-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevekuznetsov stevekuznetsov stevekuznetsov left review comments

@ncdc ncdc ncdc approved these changes

@davidfestal davidfestal Awaiting requested review from davidfestal

@kylape kylape Awaiting requested review from kylape

Assignees

@ncdc ncdc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

APIExport consumer can't wildcard list/watch its schemas until the first APIBinding is created
5 participants
@nrb @ncdc @stevekuznetsov @openshift-merge-robot @kcp-ci-bot