馃尡 remove API export reference from API binding status, make API export reference in API binding immutable #2144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
openshift-ci
bot
added
the
kind/api-change
s-urbaniak
force-pushed
the
immutable-apiexport-ref
branch
from
799be96
to
a5e5c51
Compare
sttts
reviewed
Oct 7, 2022
s-urbaniak
commented
Oct 7, 2022
s-urbaniak
commented
Oct 7, 2022
s-urbaniak
force-pushed
the
immutable-apiexport-ref
branch
from
a5e5c51
to
bec3757
Compare
s-urbaniak
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
s-urbaniak
force-pushed
the
immutable-apiexport-ref
branch
from
bec3757
to
2574da8
Compare
ncdc
suggested changes
Oct 10, 2022
openshift-merge-robot
added
the
needs-rebase
s-urbaniak
force-pushed
the
immutable-apiexport-ref
branch
from
2574da8
to
c25a2ba
Compare
openshift-merge-robot
removed
the
needs-rebase
|
/lgtm |
openshift-ci
bot
added
lgtm
s-urbaniak
force-pushed
the
immutable-apiexport-ref
branch
from
c25a2ba
to
9417758
Compare
ncdc
reviewed
Oct 13, 2022
s-urbaniak
force-pushed
the
immutable-apiexport-ref
branch
from
9417758
to
a0fa682
Compare
ncdc
approved these changes
Oct 13, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ncdc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is WIP, checking e2e tests.
I am adding more text to make e2e really happy, also this will fix some things, like API export immutability.
Let's see if this is enough to make the bots happy.
Related issue(s)
Fixes #2051