Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃尡 Remove fake client from namespacelifecycle test #2162

Merged
merged 1 commit into from
Oct 11, 2022
Merged

馃尡 Remove fake client from namespacelifecycle test #2162

merged 1 commit into from
Oct 11, 2022

Conversation

ncdc
Copy link
Member

@ncdc ncdc commented Oct 10, 2022

Summary

  • Remove fake client usage from namespacelifecycle unit test
  • Remove other unnecessary setup from the test (it wasn't being used/invoked)
  • Update the admission struct to use a function pointer for getClusterWorkspace

Related issue(s)

Fixes #

@openshift-ci openshift-ci bot added the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label Oct 10, 2022
@ncdc ncdc changed the title 馃檲 Remove fake client from namespacelifecycle test 馃尡 Remove fake client from namespacelifecycle test Oct 10, 2022
@stevekuznetsov stevekuznetsov mentioned this pull request Oct 11, 2022
Open
15 tasks
@ncdc
Remove fake client from namespacelifecycle test
a33ceab 
Signed-off-by: Andy Goldstein <andy.goldstein@redhat.com>
@stevekuznetsov
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 11, 2022
@ncdc
Copy link
Member Author

ncdc commented Oct 11, 2022

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 11, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ncdc, stevekuznetsov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 11, 2022
@ncdc
Copy link
Member Author

ncdc commented Oct 11, 2022

e2e-sharded seems to have flaked on kcp-dev/contrib-tmc#89

@openshift-merge-robot openshift-merge-robot merged commit 3a4446b into kcp-dev:main Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevekuznetsov stevekuznetsov stevekuznetsov left review comments

@qiujian16 qiujian16 Awaiting requested review from qiujian16

@sttts sttts Awaiting requested review from sttts

Assignees

@stevekuznetsov stevekuznetsov

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ncdc @stevekuznetsov @openshift-merge-robot