✨ Update kcp sync command to support global kubernetes APIExport #2164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiujian16
force-pushed
the
global-export
branch
5 times, most recently
from
2a0978e
to
af83817
Compare
openshift-merge-robot
added
the
needs-rebase
qiujian16
force-pushed
the
global-export
branch
from
af83817
to
77a519e
Compare
openshift-merge-robot
removed
the
needs-rebase
qiujian16
changed the title
qiujian16
force-pushed
the
global-export
branch
from
77a519e
to
8d3c5f6
Compare
davidfestal
reviewed
Oct 13, 2022
pkg/reconciler/workload/defaultplacement/defaultplacement_controller.go
Outdated
Show resolved
Hide resolved
pkg/reconciler/workload/defaultplacement/defaultplacement_controller.go
Outdated
Show resolved
Hide resolved
qiujian16
force-pushed
the
global-export
branch
2 times, most recently
from
2b0501c
to
1aa9bf2
Compare
1. use global kubernetes APIExport to sync by default 2. user can add additional export or resource using --apiexport and --resources flag 3. use "--resources deployment.apps --apiexport" keep the previous behavior
1. create only when at least on synctarget support it 2. skip adding certain APIResourceSchema to local kubernetes APIExport when at leat one synctarget supports global kubernetes APIExport
qiujian16
force-pushed
the
global-export
branch
from
1aa9bf2
to
0ef43d4
Compare
|
@davidfestal I reorganize the commit, PTAL again. Thanks |
1 task
davidfestal
approved these changes
Oct 17, 2022
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davidfestal The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davidfestal The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jian Qiu jqiu@redhat.com
Summary
This is to introduce the export flag in sync command. After this fix, the fix includes
After this change, the sync command will be changed:
kubectl kcp syncwithout resource flag will sync resources in kubernetes APIExport in root:compute workspacekubectl kcp sync --resources xxxwill sync both resources specified in the flag and kubernetes APIExport in root:compute workspacekubectl kcp sync --apiexports workspace1|export1will sync resources in specified export.kubectl kcp sync --resources xxx --apiexportswill sync resource xxx but not those in kubernetes APIExport in root:compute workspace.Related issue(s)
Fixes #1960