[release-0.9] 馃悰 Fix permissionclaim patch thrashing #2175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add map keys to APIBinding.Status.AppliedPermissionClaims and .ExportPermissionClaims - Switched to using a sorted list when calculating applied permission claims so it doesn't keep generating new patches because of different ordering in the list. Signed-off-by: Andy Goldstein <andy.goldstein@redhat.com>
openshift-ci
bot
added
the
kind/api-change
ncdc
approved these changes
Oct 11, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ncdc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
sttts
reviewed
Oct 12, 2022
| @@ -312,6 +319,10 @@ spec: | |||
| - resource | |||
| type: object | |||
| type: array | |||
| x-kubernetes-list-map-keys: | |||
| - group | |||
| - resource | |||
There was a problem hiding this comment.
This is wrong. It cannot be a map. group-resource won't be unique.
There was a problem hiding this comment.
with the upcoming permission claim changes this indeed will not be unique any more. there will be multiple group/resource entries, one per resourceName/Selector and separate verb list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #2174
/assign ncdc