Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Implements Upsyncer Virtual Workspace #2180

Merged
merged 7 commits into from
Nov 10, 2022
Merged

✨ Implements Upsyncer Virtual Workspace #2180

merged 7 commits into from
Nov 10, 2022

Conversation

jmprusi
Copy link
Member

@jmprusi jmprusi commented Oct 12, 2022 •
edited

Summary

Implementation of a VirtualWorkspace for the Upsync of resources (Downstream to Upstream).

  • Refactor the syncer virtual workspace to return multiple workpsaces
  • New Upsync VW
  • Transformations for the Upsync VW.

Related issue(s)

Fixes #2141

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 12, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 12, 2022
@jmprusi jmprusi changed the title WIP: Upsyncer VW ✨ [WIP] Upsyncer VW Oct 17, 2022
@jmprusi jmprusi force-pushed the 2141-implement-invert-syncing-virtual-workspace-with-transformations branch from 3b8c8f0 to 11f6091 Compare October 17, 2022 12:13
@jmprusi jmprusi changed the title ✨ [WIP] Upsyncer VW ✨ Upsyncer VW Oct 17, 2022
@jmprusi jmprusi marked this pull request as ready for review October 17, 2022 13:51
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 17, 2022
@jmprusi jmprusi force-pushed the 2141-implement-invert-syncing-virtual-workspace-with-transformations branch 2 times, most recently from a30b70d to 53dd0c6 Compare October 18, 2022 14:44
@jmprusi jmprusi changed the title ✨ Upsyncer VW ✨ Implements Upsyncer Virtual Workspace Oct 18, 2022
@jmprusi jmprusi force-pushed the 2141-implement-invert-syncing-virtual-workspace-with-transformations branch 8 times, most recently from 5cb1709 to cf8b95c Compare October 21, 2022 14:23
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 22, 2022
@jmprusi jmprusi force-pushed the 2141-implement-invert-syncing-virtual-workspace-with-transformations branch from cf8b95c to d8641f0 Compare October 27, 2022 12:12
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 27, 2022
@jmprusi jmprusi force-pushed the 2141-implement-invert-syncing-virtual-workspace-with-transformations branch 2 times, most recently from 7feb0ff to 69ec738 Compare October 27, 2022 12:22
@davidfestal davidfestal mentioned this pull request Oct 27, 2022
Merged
@jmprusi jmprusi force-pushed the 2141-implement-invert-syncing-virtual-workspace-with-transformations branch from 69ec738 to 5515b55 Compare October 27, 2022 12:28
davidfestal
davidfestal reviewed Oct 27, 2022
View reviewed changes
pkg/virtual/syncer/builder/build.go Outdated Show resolved Hide resolved
pkg/virtual/syncer/builder/build.go Outdated Show resolved Hide resolved
pkg/virtual/syncer/builder/build.go Outdated Show resolved Hide resolved
pkg/virtual/syncer/builder/build.go Outdated Show resolved Hide resolved
pkg/virtual/syncer/builder/forwarding.go Outdated Show resolved Hide resolved
pkg/virtual/syncer/builder/forwarding.go Outdated Show resolved Hide resolved
pkg/virtual/syncer/controllers/apireconciler/syncer_apireconciler_controller.go Outdated Show resolved Hide resolved
@jmprusi jmprusi force-pushed the 2141-implement-invert-syncing-virtual-workspace-with-transformations branch from 5515b55 to 42763e9 Compare October 27, 2022 15:45
@jmprusi jmprusi force-pushed the 2141-implement-invert-syncing-virtual-workspace-with-transformations branch from 06647da to a3a9397 Compare November 5, 2022 10:08
@davidfestal
Copy link
Member

In addition to the last comments I added, we should rewrite history with just the meaningful commits before merging.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 7, 2022
@jmprusi jmprusi force-pushed the 2141-implement-invert-syncing-virtual-workspace-with-transformations branch 2 times, most recently from 053b352 to c56527c Compare November 8, 2022 18:30
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 8, 2022
@jmprusi
Copy link
Member Author

jmprusi commented Nov 8, 2022

OOMKilled let's see if it was a flake or there's something broken

/retest

@jmprusi jmprusi force-pushed the 2141-implement-invert-syncing-virtual-workspace-with-transformations branch from c56527c to 1af3671 Compare November 8, 2022 20:45
@jmprusi jmprusi force-pushed the 2141-implement-invert-syncing-virtual-workspace-with-transformations branch from 1af3671 to 3a67236 Compare November 9, 2022 18:28
@jmprusi jmprusi force-pushed the 2141-implement-invert-syncing-virtual-workspace-with-transformations branch from 552a511 to bc6ef9b Compare November 9, 2022 18:52
@jmprusi
Copy link
Member Author

jmprusi commented Nov 10, 2022

/retest

jmprusi and others added 3 commits November 10, 2022 12:30
@davidfestal
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 10, 2022
@sttts
Copy link
Member

sttts commented Nov 10, 2022

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 10, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 10, 2022
@openshift-merge-robot openshift-merge-robot merged commit c8b2b88 into kcp-dev:main Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidfestal davidfestal davidfestal left review comments

@stevekuznetsov stevekuznetsov stevekuznetsov left review comments

@ncdc ncdc Awaiting requested review from ncdc

@shawn-hurley shawn-hurley Awaiting requested review from shawn-hurley

Assignees

@davidfestal davidfestal

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement Invert Syncing Virtual Workspace with transformations
5 participants
@jmprusi @davidfestal @sttts @stevekuznetsov @openshift-merge-robot