馃尡 e2e framework: introduce KcpConfigOption function #2197
Conversation
Allows for providing a custom configuration when creating a `PrivateKcpServer`. Could be extended in the future to `SharedKcpServer`
| cfg.DataDir = dataDir | ||
| return cfg | ||
| } | ||
| } |
There was a problem hiding this comment.
why isn't this the default to have independent artifact and data dirs?
There was a problem hiding this comment.
The scratch dirs are provided/generated by default by the test framework. See https://github.com/kcp-dev/kcp/pull/2197/files#diff-6119c8a3bef16c15807ae827fde6e0f6b9e6d893969064b4cc24063755a90fffR106 and https://github.com/kcp-dev/kcp/pull/2197/files#diff-6119c8a3bef16c15807ae827fde6e0f6b9e6d893969064b4cc24063755a90fffR141
There was a problem hiding this comment.
The PrivateKcpServer was extended so that the scratch dirs can be provided externally by the test.
There was a problem hiding this comment.
if they are created already, is the problem that you cannot access them?
There was a problem hiding this comment.
I wanted to create these files before starting my tests, so that the cache-server artifact, data are placed in the same location.
There was a problem hiding this comment.
I cannot rely on the PrivateKcpServer method because it immediately starts the kcp server.
There was a problem hiding this comment.
and in a standalone mode the kcp requires a path to kubeconifig that holds config for the cache-server
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/retest |
Summary
Allows for providing a custom configuration when creating a
PrivateKcpServer. Could be extended in the future toSharedKcpServerIt will be used in #2132. The
PrivateKcpServerwill be created withWithScratchDirectories. The scratch directories will be shared with an instance ofthe cache serverRelated issue(s)
part of #342