馃悰 cache: fix a datarace #2226
Merged
馃悰 cache: fix a datarace #2226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sttts
reviewed
Oct 19, 2022
| if err := s.apiextensions.GenericAPIServer.AddPostStartHook("bootstrap-cache-server", func(hookContext genericapiserver.PostStartHookContext) error { | ||
| logger = logger.WithValues("postStartHook", "bootstrap-cache-server") |
There was a problem hiding this comment.
the context of the hook lacks potentially some keys.
the logger object needs to be created when a webhook is created
otherwise it can be accessed from multiple goroutines.
==================
WARNING: DATA RACE
Read at 0x00c000b59a28 by goroutine 212:
runtime.racereadrange()
<autogenerated>:1 +0x1b
k8s.io/apiserver/pkg/server.runPostStartHook.func1()
/go/pkg/mod/github.com/kcp-dev/kubernetes/staging/src/k8s.io/apiserver@v0.0.0-20221005071841-6cfb7d485cbf/pkg/server/hooks.go:198 +0xa1
k8s.io/apiserver/pkg/server.runPostStartHook()
/go/pkg/mod/github.com/kcp-dev/kubernetes/staging/src/k8s.io/apiserver@v0.0.0-20221005071841-6cfb7d485cbf/pkg/server/hooks.go:199 +0xda
k8s.io/apiserver/pkg/server.(*GenericAPIServer).RunPostStartHooks.func2()
/go/pkg/mod/github.com/kcp-dev/kubernetes/staging/src/k8s.io/apiserver@v0.0.0-20221005071841-6cfb7d485cbf/pkg/server/hooks.go:165 +0xb4
Previous write at 0x00c000b59a28 by goroutine 210:
github.com/kcp-dev/kcp/pkg/cache/server.(*Server).PrepareRun.func1()
/go/src/github.com/kcp-dev/kcp/pkg/cache/server/server.go:57 +0x196
k8s.io/apiserver/pkg/server.runPostStartHook.func1()
/go/pkg/mod/github.com/kcp-dev/kubernetes/staging/src/k8s.io/apiserver@v0.0.0-20221005071841-6cfb7d485cbf/pkg/server/hooks.go:198 +0xa1
k8s.io/apiserver/pkg/server.runPostStartHook()
/go/pkg/mod/github.com/kcp-dev/kubernetes/staging/src/k8s.io/apiserver@v0.0.0-20221005071841-6cfb7d485cbf/pkg/server/hooks.go:199 +0xda
k8s.io/apiserver/pkg/server.(*GenericAPIServer).RunPostStartHooks.func2()
/go/pkg/mod/github.com/kcp-dev/kubernetes/staging/src/k8s.io/apiserver@v0.0.0-20221005071841-6cfb7d485cbf/pkg/server/hooks.go:165 +0xb4
Goroutine 212 (running) created at:
k8s.io/apiserver/pkg/server.(*GenericAPIServer).RunPostStartHooks()
/go/pkg/mod/github.com/kcp-dev/kubernetes/staging/src/k8s.io/apiserver@v0.0.0-20221005071841-6cfb7d485cbf/pkg/server/hooks.go:165 +0x167
k8s.io/apiserver/pkg/server.preparedGenericAPIServer.NonBlockingRun()
/go/pkg/mod/github.com/kcp-dev/kubernetes/staging/src/k8s.io/apiserver@v0.0.0-20221005071841-6cfb7d485cbf/pkg/server/genericapiserver.go:572 +0x28a
k8s.io/apiserver/pkg/server.preparedGenericAPIServer.Run()
/go/pkg/mod/github.com/kcp-dev/kubernetes/staging/src/k8s.io/apiserver@v0.0.0-20221005071841-6cfb7d485cbf/pkg/server/genericapiserver.go:497 +0x7c8
github.com/kcp-dev/kcp/pkg/cache/server.preparedServer.Run()
/go/src/github.com/kcp-dev/kcp/pkg/cache/server/server.go:84 +0x93
github.com/kcp-dev/kcp/test/e2e/reconciler/cache.TestAllScenariosAgainstStandaloneCacheServer.func1()
/go/src/github.com/kcp-dev/kcp/test/e2e/reconciler/cache/replication_test.go:230 +0x67
Goroutine 210 (running) created at:
k8s.io/apiserver/pkg/server.(*GenericAPIServer).RunPostStartHooks()
/go/pkg/mod/github.com/kcp-dev/kubernetes/staging/src/k8s.io/apiserver@v0.0.0-20221005071841-6cfb7d485cbf/pkg/server/hooks.go:165 +0x167
k8s.io/apiserver/pkg/server.preparedGenericAPIServer.NonBlockingRun()
/go/pkg/mod/github.com/kcp-dev/kubernetes/staging/src/k8s.io/apiserver@v0.0.0-20221005071841-6cfb7d485cbf/pkg/server/genericapiserver.go:572 +0x28a
k8s.io/apiserver/pkg/server.preparedGenericAPIServer.Run()
/go/pkg/mod/github.com/kcp-dev/kubernetes/staging/src/k8s.io/apiserver@v0.0.0-20221005071841-6cfb7d485cbf/pkg/server/genericapiserver.go:497 +0x7c8
github.com/kcp-dev/kcp/pkg/cache/server.preparedServer.Run()
/go/src/github.com/kcp-dev/kcp/pkg/cache/server/server.go:84 +0x93
github.com/kcp-dev/kcp/test/e2e/reconciler/cache.TestAllScenariosAgainstStandaloneCacheServer.func1()
/go/src/github.com/kcp-dev/kcp/test/e2e/reconciler/cache/replication_test.go:230 +0x67
==================
p0lyn0mial
force-pushed
the
cache-data-race
branch
from
8447b7d
to
68bf8dc
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
the logger object needs to be created when a webhook is created otherwise it can be accessed from multiple goroutines.
Related issue(s)
part of #342