Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃摉 Remove reference to APIExport's status.resourceSchemasInUse (field was removed) #2233

Merged
merged 1 commit into from
Oct 19, 2022

Conversation

fgiloux
Copy link
Contributor

@fgiloux fgiloux commented Oct 19, 2022

Summary

Remove a comment referencing a field status.resourceSchemasInUse, which does not exist. I also verified that there is no finalizer based mechanism in place that would match the behavior described in the comment.

Signed-off-by: Frederic Giloux fgiloux@redhat.com

Signed-off-by: Frederic Giloux <fgiloux@redhat.com>
@openshift-ci openshift-ci bot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 19, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 19, 2022

Hi @fgiloux. Thanks for your PR.

I'm waiting for a kcp-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 19, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 19, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ncdc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 19, 2022
@ncdc
Copy link
Member

ncdc commented Oct 19, 2022

/retitle 馃摉 Remove reference to APIExport's status.resourceSchemasInUse (field was removed)

@openshift-ci openshift-ci bot changed the title 馃悰 Remove leftover comment 馃摉 Remove reference to APIExport's status.resourceSchemasInUse (field was removed) Oct 19, 2022
@ncdc
Copy link
Member

ncdc commented Oct 19, 2022

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 19, 2022
@openshift-merge-robot openshift-merge-robot merged commit 289d732 into kcp-dev:main Oct 19, 2022
@fgiloux fgiloux deleted the apiexport branch October 25, 2022 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants